Fix the formatting of the ar-SA culture date in "Working with calendars"#53877
Fix the formatting of the ar-SA culture date in "Working with calendars"#53877BartoszKlonowski wants to merge 4 commits into
ar-SA culture date in "Working with calendars"#53877Conversation
JVimes
left a comment
There was a problem hiding this comment.
I left a couple comments. I think the only change necessary is switching to the custom format strings. Thanks!
There was a problem hiding this comment.
Hello. Thank you for the contribution! I don't think this is the correct solution though. There are a few things at play here.
-
The example is showing the culture specific short-date format string. By removing that and forcing a Gregorian format, that kind of defeats the purpose of demonstrating how a culture's calendar and format is different.
-
The original ???? error is because the terminal being used is probably older and it can't display the glyphs used by the culture.
-
The reason the strings are so different in format is because the last time the example was updated was for .NET Framework. In .NET 10 (or at some point between the two versions) the culture format string has been changed.
I feel like the real solution is to just update the expected results with what is current, then add a small note that says the output may differ based on Operating System and version of .NET and .NET Framework.
Also, the corresponding VB example needs to be updated.
Update: The reason the snippets are failing is that it's in our old snippet area and format. I can help fix that when you're ready.
|
Thank you, @adegeo. I confirm the question marks are placeholders for glyphs. @BartoszKlonowski, the glyphs show up if I call |
This pull request fixes #53856 by:
arSA.DateTimeFormat.Calendarto the proper calendar every time the culture is changed.Internal previews