[6.1.7 Cherry-pick] AE tests: create ConversionTests keys once per class to slow error 3807 identifier exhaustion - #4486
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
paulmedynski
force-pushed
the
dev/automation/pr-4478-to-6.1.7
branch
from
July 30, 2026 16:31
333b05f to
2d882aa
Compare
paulmedynski
changed the title
paulmedynski
approved these changes
Jul 30, 2026
paulmedynski
marked this pull request as ready for review
July 30, 2026 16:32
paulmedynski
enabled auto-merge (squash)
July 30, 2026 16:33
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). 3 pipeline(s) were filtered out due to trigger conditions. |
Contributor
There was a problem hiding this comment.
Pull request overview
Backports the Always Encrypted (AE) manual test change that reduces SQL Server error 3807 (“all available identifiers have been exhausted”) by creating the ConversionTests CMK/CEK once per test class (xUnit class fixture) instead of once per test case.
Changes:
- Adds
ConversionTestFixtureto create/drop a single CMK/CEK per test class across the AE setup connection strings. - Refactors
ConversionTeststo consume the fixture’s shared CEK and removes per-test CMK/CEK creation/teardown. - Updates the ManualTests project’s explicit compile list to include the new fixture file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj | Adds the new fixture to the ManualTests explicit compile includes. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/TestFixtures/ConversionTestFixture.cs | Introduces a class fixture that creates CMK/CEK once per class and drops them on dispose. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ConversionTests.cs | Switches to IClassFixture<ConversionTestFixture> and removes per-test key creation/drop logic. |
cheenamalhotra
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports #4478 to
release/6.1.This change creates the Always Encrypted
ConversionTestskeys once per test class instead of once per test, slowing SQL Server error 3807 identifier exhaustion. The backport also adds the newConversionTestFixtureto the ManualTests project's explicit compile list.There are no public API changes.
Issues
Backport of #4478.
Testing
Not run locally. This is a release-branch backport of existing manual test coverage; the release branch's explicit compile list was updated for the new fixture.