[7.0.3 Cherry-pick] AE tests: create ConversionTests keys once per class to slow error 3807 identifier exhaustion - #4485
Open
github-actions[bot] wants to merge 2 commits into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
…07 identifier exhaustion (#4478)
paulmedynski
force-pushed
the
dev/automation/pr-4478-to-7.0.3
branch
from
July 29, 2026 16:39
14dd39e to
f255ee5
Compare
paulmedynski
changed the title
paulmedynski
previously approved these changes
Jul 29, 2026
paulmedynski
marked this pull request as ready for review
July 29, 2026 16:44
paulmedynski
enabled auto-merge (squash)
July 29, 2026 16:45
Contributor
There was a problem hiding this comment.
Pull request overview
Backport of the upstream fix to reduce SQL Server error 3807 (“identifier exhaustion”) in Always Encrypted manual tests by creating the CMK/CEK once per ConversionTests class instead of once per test case.
Changes:
- Added
ConversionTestFixture(IClassFixture) that creates a shared CMK+CEK once per test class and drops them on fixture disposal. - Refactored
ConversionTeststo consume the shared CEK from the fixture and to only drop per-test tables inDispose().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/TestFixtures/ConversionTestFixture.cs | New class fixture that creates/drops shared CMK/CEK for ConversionTests. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/ConversionTests.cs | Switches from per-test constructor key creation to using the shared fixture CEK; keeps per-test table lifecycle. |
paulmedynski
approved these changes
Jul 29, 2026
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports #4478 to
release/7.0for the 7.0.3 servicing release. The cherry-pick conflicts have been resolved manually.This fixes recurring SQL Server error 3807 (
Create failed because all available identifiers have been exhausted.) in the Always Encrypted manual tests.ConversionTestspreviously created a Column Master Key and Column Encryption Key for every test case, advancing SQL Server's monotonic per-database identifier counter even after the keys were dropped.The change adds an
IClassFixturethat creates the keys once per test class and drops them when the fixture is disposed. Per-test tables continue to be created and dropped for each case. This substantially reduces key identifier consumption without changing the public API.Issues
Backport of #4478.
Testing
sqlclient-ci-kerberosrun 20260727.4.release/7.0; resulting branch contains the expected two-file change.