Skip to content

Test: remove flaky markers from stabilised tests #4483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cheenamalhotra wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −5
Open

Test: remove flaky markers from stabilised tests #4483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
060b801
Remove stabilized DateTime variant flaky markers
cheenamalhotra Jul 29, 2026
053ab0e
Remove additional stabilized test markers
cheenamalhotra Jul 29, 2026
8f15789
Preserve environment-sensitive flaky markers
cheenamalhotra Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataStreamTest/DataStreamTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,6 @@ public static void GetXmlReader_ReturnsXmlReaderCorrectly(string connectionStrin
// Enumeration is disabled to prevent generating empty test set when connection strings are not setup.
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
[MemberData(nameof(ConnectionStrings), DisableDiscoveryEnumeration = true)]
[Trait("Category", "flaky")]
public static void ReadStream_ReadsStreamDataCorrectly(string connectionString)
{
ReadStream(connectionString);
Expand Down
11 changes: 10 additions & 1 deletion src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/DateTimeVariantTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public TestResult(object value, string baseTypeName)
/// Tests for DateTime variant parameters with different date/time types.
/// </summary>
[Trait("Set", "3")]
[Trait("Category", "flaky")]
public class DateTimeVariantTests
{
private static void RunTest(
Expand Down Expand Up @@ -125,6 +124,7 @@ private static void xsql(SqlConnection conn, string sql)
cmd.ExecuteNonQuery();
}

[Trait("Category", "flaky")]
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
[MemberData(nameof(GetParameterCombinations), DisableDiscoveryEnumeration = true)]
public void TestSimpleParameter_Type(
Expand Down Expand Up @@ -161,6 +161,7 @@ public void TestSimpleParameter_Type(
expectedBaseTypeOverrides);
}

[Trait("Category", "flaky")]
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
[MemberData(nameof(GetParameterCombinations), DisableDiscoveryEnumeration = true)]
public void TestSimpleParameter_Variant(
Expand Down Expand Up @@ -197,6 +198,7 @@ public void TestSimpleParameter_Variant(
expectedBaseTypeOverrides);
}

[Trait("Category", "flaky")]
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
[MemberData(nameof(GetParameterCombinations), DisableDiscoveryEnumeration = true)]
public void TestSqlDataRecordParameterToTVP_Type(
Expand Down Expand Up @@ -240,6 +242,7 @@ public void TestSqlDataRecordParameterToTVP_Type(
expectedBaseTypeOverrides);
}

[Trait("Category", "flaky")]
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
[MemberData(nameof(GetParameterCombinations), DisableDiscoveryEnumeration = true)]
public void TestSqlDataRecordParameterToTVP_Variant(
Expand Down Expand Up @@ -283,6 +286,7 @@ public void TestSqlDataRecordParameterToTVP_Variant(
expectedBaseTypeOverrides);
}

[Trait("Category", "flaky")]
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
[MemberData(nameof(GetParameterCombinations), DisableDiscoveryEnumeration = true)]
public void TestSqlDataReaderParameterToTVP_Type(
Expand Down Expand Up @@ -329,6 +333,7 @@ public void TestSqlDataReaderParameterToTVP_Type(
expectedBaseTypeOverrides);
}

[Trait("Category", "flaky")]
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
[MemberData(nameof(GetParameterCombinations), DisableDiscoveryEnumeration = true)]
public void TestSqlDataReaderParameterToTVP_Variant(
Expand Down Expand Up @@ -377,6 +382,7 @@ public void TestSqlDataReaderParameterToTVP_Variant(
expectedBaseTypeOverrides);
}

[Trait("Category", "flaky")]
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
[MemberData(nameof(GetParameterCombinations), DisableDiscoveryEnumeration = true)]
public void TestSqlDataReader_TVP_Type(
Expand Down Expand Up @@ -452,6 +458,7 @@ public void TestSqlDataReader_TVP_Type(
expectedBaseTypeOverrides);
}

[Trait("Category", "flaky")]
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
[MemberData(nameof(GetParameterCombinations), DisableDiscoveryEnumeration = true)]
public void TestSqlDataReader_TVP_Variant(
Expand Down Expand Up @@ -527,6 +534,7 @@ public void TestSqlDataReader_TVP_Variant(
expectedBaseTypeOverrides);
}

[Trait("Category", "flaky")]
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
[MemberData(nameof(GetParameterCombinations), DisableDiscoveryEnumeration = true)]
public void TestSimpleDataReader_Type(
Expand Down Expand Up @@ -584,6 +592,7 @@ public void TestSimpleDataReader_Type(
expectedBaseTypeOverrides);
}

[Trait("Category", "flaky")]
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
[MemberData(nameof(GetParameterCombinations), DisableDiscoveryEnumeration = true)]
public void TestSimpleDataReader_Variant(
Expand Down
3 changes: 0 additions & 3 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/ParametersTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,6 @@ public static void Test_WithGuidValue_ShouldReturnGuid()
}

// Synapse: Parse error at line: 1, column: 8: Incorrect syntax near 'TYPE'.
[Trait("Category", "flaky")]
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
public static void TestParametersWithDatatablesTVPInsert()
{
Expand Down Expand Up @@ -287,7 +286,6 @@ public static void TestParametersWithDatatablesTVPInsert()

#if !NETFRAMEWORK
// Synapse: Parse error at line: 1, column: 8: Incorrect syntax near 'TYPE'.
[Trait("Category", "flaky")]
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
public static void TestParametersWithSqlRecordsTVPInsert()
{
Expand Down Expand Up @@ -379,7 +377,6 @@ public static void TestDateOnlyTVPDataTable_CommandSP()
cmd.ExecuteNonQuery();
}

[Trait("Category", "flaky")]
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
public static void TestDateOnlyTVPSqlDataRecord_CommandSP()
{
Expand Down
Loading