Repository navigation
Fix Android SDK CI setup and suppress netcoreapp3.1 Unsafe warning - #2627
Merged
Merged
Conversation
- Update android-actions/setup-android to v4.0.4 in build.yml and sdl2.yml to avoid deprecated tools package failure - Add SuppressTfmSupportBuildWarnings to build/props/common.props to suppress System.Runtime.CompilerServices.Unsafe warning on netcoreapp3.1 - Add RollForward Major to Silk.NET.NUKE.csproj so NUKE can execute on .NET 8+ environments
Contributor
Author
|
Could someone please approve the workflow for PR #2627 when you get a chance? |
Member
|
Approved. |
Perksey
approved these changes
Oct 11, 2026
Perksey
left a comment
Perksey
left a comment
Member
There was a problem hiding this comment.
CI has been going long enough that it looks like it'll pass, and the changes look good. Thank you so much!
Perksey
enabled auto-merge (squash)
October 11, 2026 15:45
Contributor
Author
It has passed, but something seems suspicious because it shouldn’t take this long |
Contributor
Author
Thanks a lot! Really appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Resolves CI failures across GitHub Actions workflows:
Updates
android-actions/setup-androidtov4.0.4in.github/workflows/build.ymland.github/workflows/sdl2.yml. Google removed the deprecatedtoolspackage from Android SDK distribution mirrors, which causedandroid-actions/setup-android@v2to fail with exit code 1 duringsdkmanagersetup. Action version 4.0.4 replacestoolswithplatform-tools.Adds
<SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>inbuild/props/common.props.System.Runtime.CompilerServices.Unsafe 6.1.2emits a TFM compatibility warning onnetcoreapp3.1, which causedBuildLibSilkDroidto fail when warnings are treated as errors. Suppressing this warning allows MSBuild to buildnetcoreapp3.1targets under newer .NET SDKs.Adds
<RollForward>Major</RollForward>tobuild/nuke/Silk.NET.NUKE.csprojso the NUKE build project executes cleanly on runners that have .NET 8+ installed.Related issues, Discord discussions, or proposals
Related to #2622 and resolves the CI failure from run 38120826989 (job 114439401333).
Further Comments