Fix Cube.Contains checking Y upper bound twice instead of Z

[AustinAviv]

Summary of the PR

Fixes a copy-paste error in Cube<T>.Contains(Cube<T> other) where oMax.Y <= tMax.Y was checked twice, leaving the Z upper bound unchecked. Also adds unit tests covering Cube<T>.Contains for points and other cubes.

Related issues, Discord discussions, or proposals

Fixes #2625

Further Comments

[Perksey]

How embarrassing! Good spot, thank you!

[AustinAviv]

How embarrassing! Good spot, thank you!

No worries at all, easy typo to miss!

Also noticed the CI failure seems to be the Android SDK setup issue from setup-android@v2 rather than this change. Let me know if you'd like me to rebase once that gets sorted out.

[Perksey]

We've got another PR in flight to sort that so I'll probably force merge this once I get to a computer.

[AustinAviv]

We've got another PR in flight to sort that so I'll probably force merge this once I get to a computer.

Sounds good, appreciate it!

Happy to take a look into #2622 as well if helpful.

See you, Have a great day.

[Exanite]

Sounds good, appreciate it!

Happy to take a look into #2622 as well if helpful.

See you, Have a great day.

That would be great! I'm not familiar with Android dev so this would be very helpful.

[AustinAviv]

Sounds good, appreciate it!
Happy to take a look into #2622 as well if helpful.
See you, Have a great day.

That would be great! I'm not familiar with Android dev so this would be very helpful.

Sure, I’ll check the issue in Silk.NET

Android packages can be tricky & I seeing similar issues in dotnet/android too

dotnet/android#13064