Skip to content

Preserve report environment info for in-process toolchains - #3267

Merged
timcassell merged 2 commits into
dotnet:masterfrom
shubmittal:fix-inprocess-report-info-3263
Sep 20, 2026
Merged

timcassell merged 2 commits into
dotnet:masterfrom
shubmittal:fix-inprocess-report-info-3263

Conversation

@shubmittal

Copy link
Copy Markdown
Contributor

Summary

  • preserve in-process benchmark environment output in ExecuteResult.PrefixedLines
  • populate runtime, GC, and hardware-intrinsics report data for both Emit and NoEmit toolchains
  • keep internal in-process diagnoser transport lines excluded while preserving diagnoser deserialization

Fixes #3263

Validation

  • BenchmarkDotNet Release build for net10.0
  • InProcessEnvironmentInfoTests: 2 passed
  • InProcessDiagnoserTests: 291 passed
  • untouched-base smoke harness: Emit and NoEmit failed with zero prefixed lines
  • fixed smoke harness: Emit and NoEmit passed with six prefixed lines
  • scoped dotnet format whitespace --verify-no-changes
  • git diff --check

The full test suite was not run. Restore and build emitted NU1900 warnings because NuGet vulnerability data could not be fetched during a TLS handshake failure; exact declared packages were downloaded from official NuGet package endpoints for local validation without changing package versions or TLS settings.

shubmittal and others added 2 commits September 19, 2026 12:55
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
BaseMockInProcessDiagnoser.s_completedResults is static and shared by
every test using the mock in-process diagnoser, so a test that leaves
entries behind breaks the next one's exact-collection assert. The other
consumers already clear it in a finally; do the same here.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@timcassell
timcassell merged commit a33de8b into dotnet:master Sep 20, 2026
11 checks passed
@timcassell timcassell added this to the v0.16.0 milestone Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runtime, GC and HardwareIntrinsics report info is empty for in-process toolchains

2 participants