Fix multi-character newline handling in IndentedStringBuilder.TrimEnd#7
Merged
Merged
Conversation
Co-authored-by: walterlv <9959623+walterlv@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update expression code generator based on feedback
Fix multi-character newline handling in IndentedStringBuilder.TrimEnd
Nov 13, 2025
walterlv
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TrimEndmethod assumed single-character newlines, breaking whenNewLineis configured to multi-character sequences like\r\n.Changes:
FindLastNewLineIndex: Changed signature fromchartostringparameter; now searches for complete newline sequence instead of just the last character+ 1with+ NewLine.Lengthat lines 289 and 298 to properly skip/preserve the entire newline sequenceExample:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.