fix(openapi): document recover account endpoint at its registered path - #550
Merged
alexmerlin merged 1 commit intoSep 22, 2026
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is a straightforward documentation-path correction that matches the existing registered route and current functional test usage.
Review effort: Lite
Findings: None
What changed in this PR
This PR fixes an OpenAPI documentation drift in the User module by updating the OA\Post annotation for PostUserAccountRecoverHandler so the documented endpoint path matches the actual registered route.
Changes:
- Update the OpenAPI
pathfor the account recovery endpoint from/account/recover-identityto/user/account/recover. - Align generated OpenAPI output with the existing router configuration and functional test coverage.
| File | Description |
|---|---|
| src/User/src/OpenAPI.php | Updates the OA\Post annotation path to match the registered /user/account/recover route. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dq042000
force-pushed
the
fix/issue-546-recover-account-path
branch
from
September 22, 2026 07:19
032cd89 to
0f88f72
Compare
The OA\Post annotation for PostUserAccountRecoverHandler pointed to /account/recover-identity, which is not a registered route. Use /user/account/recover to match RoutesDelegator. Fixes dotkernel#546 Signed-off-by: MikeCi <dq042000@gmail.com>
dq042000
force-pushed
the
fix/issue-546-recover-account-path
branch
from
September 22, 2026 07:20
0f88f72 to
ba84334
Compare
alexmerlin
approved these changes
Sep 22, 2026
Member
|
Thanks @dq042000 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #546
The OpenAPI annotation for PostUserAccountRecoverHandler used /account/recover-identity,
but the route is registered as /user/account/recover (RoutesDelegator.php).
Changed the annotation path to match the route.