Skip to content

fix(content-drive): global search hides matches without content-type filter (#37211) - #37566

Draft
ihoffmann-dot wants to merge 1 commit into
mainfrom
issue-37211-content-drive-global-search-filter
Draft

ihoffmann-dot wants to merge 1 commit into
mainfrom
issue-37211-content-drive-global-search-filter

Conversation

@ihoffmann-dot

Copy link
Copy Markdown
Member

Summary

PR 2 (implementation) for the issue-resolution spec approved and merged in #37525.

Fixes #37211 — Content Drive's unfiltered global search silently drops matches that the same term finds once a content-type filter is applied, because the DB-order chunked scan cuts off before reaching them, while the legacy Search All portlet (querying ES directly) does not.

Draft while planning is in progress: /speckit-plan/speckit-tasks/speckit-implement/speckit-converge still need to run against specs/37418-content-drive-global/spec.md. Will move out of draft once /speckit-converge reports converged (or remaining findings are consciously accepted).

Test plan

  • TDD gate: tests written and confirmed failing before implementation (Principle V)
  • Integration test covering unfiltered global search vs. the same term with a content-type filter, same result set
  • /speckit-converge run against final code

🤖 Generated with Claude Code

Spec approved and merged in #37525. Planning (/speckit-plan, /speckit-tasks) starts here.
@claude

claude Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Claude finished @ihoffmann-dot's task in 39s —— View job


Code Review

I checked out the branch and diffed it against origin/main:

git diff origin/main...HEAD  →  (empty)
git log origin/main..HEAD    →  76d8bdfe chore(content-drive): start implementation branch for issue #37211

There is nothing to review yet. The branch contains a single commit that only carries a commit message ("Planning starts here") with no file changes — 0 additions, 0 deletions, 0 changed files. The implementation (/speckit-plan/speckit-tasks/speckit-implement/speckit-converge) described in the PR body hasn't landed on this branch.

Per the PR body this is intentional — the PR is a draft opened while planning is in progress.

What I'd expect to see before a substantive review

Based on the spec (#37211 / #37525), the fix targets Content Drive's unfiltered global search silently dropping matches due to the DB-order chunked scan cutting off. When the implementation lands, the key things to have in place:

  • TDD gate (Principle V) — the integration test comparing unfiltered global search vs. the same term with a content-type filter (same result set) written and confirmed failing (Red) before the fix.
  • Test registered in a MainSuite*/Junit5Suite* @SuiteClasses — otherwise it compiles green but is silently never run in CI.
  • /speckit-converge run against the final code, reporting converged (or remaining findings consciously accepted) before moving out of draft.

No issues found — nothing to flag in an empty diff. Re-tag me with @claude once the implementation commits are pushed and I'll do a full review.
· issue-37211-content-drive-global-search-filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Content Drive: adding a content-type filter to the global search hides matches the search alone found

1 participant