Skip to content

Enable the redesigned dotAI config page by default by removing FEATURE_FLAG_DOTAI_CONFIG_UI from dotmarketing-config #37725

Description

@nollymar

Description

#37222 added FEATURE_FLAG_DOTAI_CONFIG_UI=false to dotCMS/src/main/resources/dotmarketing-config.properties. With that default, every installation shows the restored pre-redesign dotAI config screen (DotAiConfigDetailLegacyComponent, a raw JSON editor) instead of the redesigned provider configuration page delivered under the dotAI: Provider Configuration UI epic (#36826).

The redesigned page is now ready to be the default, so the false default should be removed from dotmarketing-config.properties.

How the flag resolves once the entry is gone

The frontend guard dotAiConfigDetailMatchGuard reads the flag through DotPropertiesService.getFreshFeatureFlag. When the key has no configured value, the configuration endpoint returns FEATURE_FLAG_NOT_FOUND, and normalizeFlagValue treats that as true. So the router matches the redesigned route, and the legacy fallback route in dot-apps.routes.ts is not used.

The flag itself (the FeatureFlagName constant, the ConfigurationResource allow-list entries, the guard and the legacy component) stays in place for now. Customers can still opt back into the legacy screen with DOT_FEATURE_FLAG_DOTAI_CONFIG_UI=false. Removing the flag and the legacy screen completely is out of scope here and can be a follow-up.

Acceptance Criteria

  • The FEATURE_FLAG_DOTAI_CONFIG_UI=false entry and its comment block are removed from dotCMS/src/main/resources/dotmarketing-config.properties; no other entry in the file changes
  • On a fresh install with no override, opening the dotAI app configuration (Apps → dotAI → a site) shows the redesigned provider configuration page
  • With DOT_FEATURE_FLAG_DOTAI_CONFIG_UI=false set, the same navigation shows the legacy JSON-editor screen
  • GET /api/v1/configuration still includes the FEATURE_FLAG_DOTAI_CONFIG_UI key (value NOT_FOUND when unset, the configured value when overridden)
  • Existing unit tests for dotAiConfigDetailMatchGuard still pass

Additional Context

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions