Skip to content

fix: correct problem 3617 cycle length and date continuity - #6096

Open
dajiaohuang wants to merge 2 commits into
doocs:mainfrom
dajiaohuang:fix/generic-study-cycle-sql
Open

dajiaohuang wants to merge 2 commits into
doocs:mainfrom
dajiaohuang:fix/generic-study-cycle-sql

Conversation

@dajiaohuang

@dajiaohuang dajiaohuang commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary\n- Generate candidate cycle lengths from 3 through half of each contiguous segment.\n- Compare every subject against its corresponding position in the cycle and choose the shortest valid period.\n- Require at least three distinct subjects in the cycle.\n- Mirror the SQL and Pandas changes in both README tabs.\n\nFixes #6095\n\n## Validation\n- git diff --check\n- No tests run.\n

@idoocs idoocs added md Issues or Pull requests relate to .md files sql Issues or Pull requests relate to .sql files py Issues or Pull requests relate to .py code labels Oct 3, 2026
A repeated subject inside a block is not a longer cycle. The length is the
number of distinct subjects in a date-contiguous run, and that block must
tile the whole run for at least two cycles.
@yanglbme
yanglbme force-pushed the fix/generic-study-cycle-sql branch from 47003b2 to de0a55b Compare October 4, 2026 06:12
@cursor cursor Bot changed the title fix: check arbitrary study cycles in problem 3617 SQL fix: define problem 3617 cycle length by distinct subjects Oct 4, 2026
A later subject cycle is not a spiral when an earlier session
breaks the date run. Every adjacent pair must fall within two days.
@cursor cursor Bot changed the title fix: define problem 3617 cycle length by distinct subjects fix: correct problem 3617 cycle length and date continuity Oct 4, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

md Issues or Pull requests relate to .md files py Issues or Pull requests relate to .py code sql Issues or Pull requests relate to .sql files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants