Skip to content

fix(jev): a CLI's localhost callback is not a change of product; wait once before handing back none_chosen - #12

Merged
dohooo merged 1 commit into
mainfrom
perf/jev-cli-pages
Oct 15, 2026
Merged

dohooo merged 1 commit into
mainfrom
perf/jev-cli-pages

Conversation

@dohooo

@dohooo dohooo commented Oct 15, 2026

Copy link
Copy Markdown
Owner

In the daily 51-walk Dosu run the same 23 walks hand back to the supervising agent every day (10-12 to 10-14), and
the supervisor then spends about 34 minutes of the hour on them. Two of the causes are the executor's own rules:

  • origin_changed: the walk pins the first page's origin, and a Dosu CLI login opens a tab that ends on
    http://localhost:<port>/callback (or a file:// report page). The steps expect exactly that page, and the walk
    handed it back unread. A page on a loopback host or a local file now counts as the walk's own once the walk has a
    terminal session of its own; any other origin still ends the walk, and a browser-only walk is unchanged. The
    callback's token is masked in Jev's request by the existing query-parameter rule.
  • none_chosen: an action round that chose none handed back at once, and a CLI's "Returning to your terminal..."
    page moved on to its callback a second later. It now gets the one wait for the page to move that a checkpoint the
    page settles neither way already gets (movedBeforeHandBack, one mechanism for both); unmoved, it hands back as
    before.

Neither change lets Jev act or pass where it could not: the callback page is judged with the same holds/contradicts
questions, and the wait only reads the page again.

Checks: typecheck, lint (biome + discipline), pi lane. A local executor test (not committed) passes a walk that
lands on a localhost callback with a terminal, still ends one without a terminal or on another site, re-reads a page
that moved after none was chosen and hands back one that did not; on the previous code the two new cases fail and the
controls pass. Browser-only eval regressions on the local stack: qs-notify off/on, hd-xl off and bw-cart on correct;
bw-search-quoted on passed wrongly, which neither changed path touched (no terminal, no none) and which the control
arm also did in earlier rounds.

https://claude.ai/code/session_01QXmSJBFujofueuHrdm6TdA

… once before handing back none_chosen

In the daily 51-walk Dosu run the same 23 walks hand back to the supervising agent every day (10-12 to 10-14), and
the supervisor then spends about 34 minutes of the hour on them. Two of the causes are the executor's own rules:

- `origin_changed`: the walk pins the first page's origin, and a Dosu CLI login opens a tab that ends on
  `http://localhost:<port>/callback` (or a `file://` report page). The steps expect exactly that page, and the walk
  handed it back unread. A page on a loopback host or a local file now counts as the walk's own once the walk has a
  terminal session of its own; any other origin still ends the walk, and a browser-only walk is unchanged. The
  callback's token is masked in Jev's request by the existing query-parameter rule.
- `none_chosen`: an action round that chose none handed back at once, and a CLI's "Returning to your terminal..."
  page moved on to its callback a second later. It now gets the one wait for the page to move that a checkpoint the
  page settles neither way already gets (`movedBeforeHandBack`, one mechanism for both); unmoved, it hands back as
  before.

Neither change lets Jev act or pass where it could not: the callback page is judged with the same holds/contradicts
questions, and the wait only reads the page again.

Checks: typecheck, lint (biome + discipline), pi lane. A local executor test (not committed) passes a walk that
lands on a localhost callback with a terminal, still ends one without a terminal or on another site, re-reads a page
that moved after none was chosen and hands back one that did not; on the previous code the two new cases fail and the
controls pass. Browser-only eval regressions on the local stack: qs-notify off/on, hd-xl off and bw-cart on correct;
bw-search-quoted on passed wrongly, which neither changed path touched (no terminal, no none) and which the control
arm also did in earlier rounds.

Claude-Session: https://claude.ai/code/session_01QXmSJBFujofueuHrdm6TdA
@dohooo
dohooo merged commit a9f123a into main Oct 15, 2026
3 checks passed
@dohooo
dohooo deleted the perf/jev-cli-pages branch October 15, 2026 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant