update buildx to 0.33.0 and model to 1.2.1#1323
Open
AshwinHIBM wants to merge 1 commit into
Open
Conversation
vvoland
approved these changes
May 27, 2026
Contributor
|
#1324 should fix failures. Can you rebase once its merged? |
Signed-off-by: Ashwin Hendre <112116232+AshwinHIBM@users.noreply.github.com>
crazy-max
reviewed
May 29, 2026
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Did we not migrate to https://github.com/docker/packaging for cli plugins?
Contributor
|
Yes we (Docker) did |
vvoland
reviewed
May 29, 2026
| # DOCKER_MODEL_REF is the version of model to package. It is usually a tag, | ||
| # but can be a valid git reference in DOCKER_MODEL_REPO. | ||
| DOCKER_MODEL_REF ?= v0.1.39 | ||
| DOCKER_MODEL_REF ?= v1.2.1 |
Contributor
There was a problem hiding this comment.
Wrong version?
+ REF=FETCH_HEAD
+ git -C src/github.com/docker/model-cli fetch --update-head-ok --depth 1 origin v1.2.1
fatal: couldn't find remote ref v1.2.1
make: *** [Makefile:70: checkout-model] Error 128
Error: Process completed with exit code 2.
Author
There was a problem hiding this comment.
Thanks for pointing it out. I forgot that we replace the model-cli repository with model-runner through our build scripts. I just raised another PR for this replacement: #1325
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Bump buildx to version v0.33.0
Bump model to version v1.2.1
- Description for the changelog