fix(mcp): honor callback configuration in standalone OAuth login - #3977
Open
aheritier wants to merge 1 commit into
Open
fix(mcp): honor callback configuration in standalone OAuth login#3977aheritier wants to merge 1 commit into
aheritier wants to merge 1 commit into
Conversation
Align `debug oauth login` with the runtime's managed OAuth flow by using NewCallbackServerOnPort/ResolveRedirectURI instead of the fixed NewCallbackServer/GetRedirectURI pair, so RemoteOAuthConfig.CallbackPort and CallbackRedirectURL are honored identically in both paths.
aheritier
added
area/mcp
aheritier
marked this pull request as ready for review
August 13, 2026 17:19
melmennaoui
previously approved these changes
Aug 14, 2026
aheritier
force-pushed
the
fix/3879-debug-oauth-callback-parity
branch
from
August 14, 2026 09:23
c0d56cf to
58e48ae
Compare
aheritier
force-pushed
the
fix/3879-debug-oauth-callback-parity
branch
from
August 14, 2026 10:12
58e48ae to
6b44997
Compare
aheritier
force-pushed
the
fix/3879-debug-oauth-callback-parity
branch
from
August 14, 2026 10:40
6b44997 to
c0d56cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone debug OAuth login now aligns with runtime
callbackPort/callbackRedirectURLbehavior usingNewCallbackServerOnPortandResolveRedirectURI.The resolved redirect URI is consistent across DCR, authorize, callback, and token exchange. Default behavior is unchanged.
Tests cover configured port, redirect URL placeholder, explicit-client/no-DCR, and bind failure.
Stacked on #3959, #3955, and #3881.
Validation:
go test ./pkg/tools/mcp/... ./cmd/root/...go test ./e2e -run TestDependenciesManual validation