fix(review-pr): fail closed on incomplete sub-agent output - #82
Open
Sayt-0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
A structured-output child response terminated with
stop_reason: refusalwas returned bytransfer_taskas successful partial JSON.This change provides action-side containment. It does not change Docker Agent runtime semantics: refusal, structured-output length termination, and native schema validation still require a separate upstream fix.
Observed run: https://github.com/docker/sandboxes/actions/runs/31797481426
Expectation mapping
transfer_taskfailmax_tokenstermination fails equivalentlyline >= 1and meaningful stringsfinding_idpairing plus exact file and line cross-checkValidation
origin/main