Skip to content

fix(scale): reject empty service name in --scale flag - #14481

Open
arsalanyavari wants to merge 1 commit into
docker:mainfrom
arsalanyavari:fix-scale-empty-service
Open

arsalanyavari wants to merge 1 commit into
docker:mainfrom
arsalanyavari:fix-scale-empty-service

Conversation

@arsalanyavari

Copy link
Copy Markdown

What this PR does

Fixes --scale flag validation in docker compose up / create when an empty service name is passed (e.g. --scale "=2").

Currently, applyScaleOpts only checks !ok || val == "", missing the empty service name check (name == ""). As a result, passing an empty service name passes flag validation and fails later during service lookup with no such service: : not found.

This change adds name == "" to the validation check in applyScaleOpts, aligning it with cmd/compose/scale.go to reject the syntax upfront with a clear CLI error:
invalid --scale option "=2". Should be SERVICE=NUM.

Related issue

Fixes #14480

Changes made

  • Added name == "" check to applyScaleOpts in cmd/compose/create.go (consistent with cmd/compose/scale.go).
  • Added test assertion for empty service name ("=2") to existing TestApplyScaleOpt in cmd/compose/up_test.go.

Testing done

  • Unit tests pass: make test

  • E2E tests pass: make e2e-compose or make e2e-compose-standalone

  • Linting passes: make lint

  • Code formatted: make fmt

  • Manually tested (describe):

    • Before:
      $ docker compose up --dry-run --scale "=2"
      no such service: : not found
      
    • After:
      $ ./bin/build/docker-compose -f compose.yaml up --dry-run --scale "=2"
      invalid --scale option "=2". Should be SERVICE=NUM
      
    • Verified valid scale options still work as expected (--scale "web=2").

AI tool used (if applicable)

AI Tool:

Additional context

(not mandatory) A picture of a cute animal, if possible in relation to what you did

shiba inu

Signed-off-by: arsalanyavari <arya48.yavari79@gmail.com>
@arsalanyavari
arsalanyavari requested review from a team as code owners November 10, 2026 00:51
@arsalanyavari
arsalanyavari requested review from glours and ndeloof and a balanced review from Copilot November 10, 2026 00:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] docker compose up --scale with empty service name results in "no such service: : not found" instead of syntax error

2 participants