Repository navigation
refactor(tracing): use cli provided tracer - #14382
Open
jsternberg wants to merge 1 commit into
Open
jsternberg wants to merge 1 commit into
jsternberg wants to merge 1 commit into
Conversation
jsternberg
force-pushed
the
cli-otel-providers
branch
from
October 23, 2026 18:48
f002d4c to
2c3a076
Compare
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🔴 CRITICAL
Two confirmed issues introduced by this PR:
- [high/security] go.mod:144 — The
replacedirective redirectsgithub.com/docker/clito a personal fork (jsternberg/cli) outside Docker's control. This must not be merged. - [medium] internal/tracing/tracing.go:56 —
InitProvidernow returns a no-op shutdown, causing buffered OTLP spans to be silently dropped on process exit (regression from prior behavior; the PR description acknowledges the upstream fix is not yet shipped).
jsternberg
force-pushed
the
cli-otel-providers
branch
from
October 23, 2026 19:01
2c3a076 to
cd080c2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
Need to wait for a docker/cli release before we can merge this one |
jsternberg
force-pushed
the
cli-otel-providers
branch
2 times, most recently
from
November 5, 2026 19:04
ac6c46c to
dd0715a
Compare
Use the docker/cli library provided tracer rather than create and manage our own. This has the benefit of less code and it puts the correct setup of the docker telemetry tracer into the same one the core cli and buildx use. This also allows compose to use the same debug environment variables that the cli and buildx use for testing telemetry. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
cli-otel-providers
branch
from
November 9, 2026 16:42
dd0715a to
36e496c
Compare
docker-agent
reviewed
Nov 9, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the docker/cli library provided tracer rather than create and manage
our own. This has the benefit of less code and it puts the correct setup
of the docker telemetry tracer into the same one the core cli and buildx
use.
This also allows compose to use the same debug environment variables
that the cli and buildx use for testing telemetry.
This relies on docker/cli#7433 to work properly since
the current
docker/clilibrary doesn't currently correctly shut down thetracer and meter provider.