test(build): re-enable wrong ssh key id test - #14120
Open
htoyoda18 wants to merge 1 commit into
Open
Conversation
moby/buildkit#5558, which this test was disabled for, is fixed and released well before the buildkit v0.26.3 currently vendored here. Verified the re-enabled case passes (3 consecutive runs). Signed-off-by: hiroto.toyoda <hiroto.toyoda@dena.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Re-enabled the
build failed with wrong ssh key id from CLIsubtest inTestBuildSSH, which was disabled with a FIXME waiting on moby/buildkit#5558. That issue (a regression where--no-cachewas ignored, introduced in buildkit v0.17.2) was fixed and closed in December 2024 — well before the buildkit v0.26.3 currently vendored in go.mod.Verified locally: the re-enabled subtest passes as part of
TestBuildSSH(go test -tags e2e ./pkg/e2e/ -run TestBuildSSH -v), including 3 consecutive runs with no flakiness. The build output shows the expectedunset ssh forward key fake-ssherror.Related issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did