Close the ttyWriter done channel after context cancel - #14115
Close the ttyWriter done channel after context cancel#14115Hashim1999164 wants to merge 1 commit into
Conversation
Signed-off-by: Hashim1999164 <64767361+Hashim1999164@users.noreply.github.com>
|
Thanks for opening this — the underlying bug (
today:
We reproduced the panic against this PR's diff on all three paths. A correct fix needs to avoid opening a second bracket on the shared bus in the first place (the unexported methods should be called directly there, as Separately: this account's recent activity, near-simultaneous, template-identical PRs opened across dozens of unrelated, high-profile repositories over the last few days, matches the pattern of low-effort, automated AI-generated contribution farming. We don't accept that kind of submission on docker/compose. |
|
Okay @glours |
Summary
Fixes #14114
ttyWriter.Donesent on an unbuffered channel. After SIGTERM the render goroutine exits throughctx.Done()and never receives, soDoneblocked forever. Closing the channel returns immediately even when that goroutine is already gone.Test plan
go test ./cmd/display/TestDoneAfterContextCancelDoesNotHangcovers cancel thenDone