cli/image: reject pull references with both tag and digest - #7181
Open
locker95 wants to merge 1 commit into
Open
cli/image: reject pull references with both tag and digest#7181locker95 wants to merge 1 commit into
locker95 wants to merge 1 commit into
Conversation
NAME:tag@digest is a valid reference form, but pull used the digest and left the image untagged, which looked like a silent no-op for the tag. Match the use line (TAG or DIGEST) and fail early with a clear error. Fixes docker#2856 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker pull name:tag@sha256:…used to pull by digest and leave the image untagged, so the tag looked like it was ignored with no error. Use line is alreadyNAME[:TAG|@DIGEST]— reject the combined form up front.Also notes the rule in the pull docs.
Fixes #2856