formatter: round human durations for CREATED columns - #7179
Open
locker95 wants to merge 1 commit into
Open
Conversation
CLI CREATED fields used go-units HumanDuration, which floors day/week values while Docker Desktop rounds. Localize a small HumanDuration with consistent round-half-up so image/container listings match Desktop more closely without vendoring frozen go-units changes. Fixes docker#6891 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker image ls/psCREATED text could disagree with Docker Desktop for mid-range ages (e.g. ~4 days showing as 3) because go-units floors day/week units.Added
internal/duration.HumanDurationwith round-half-up at day/week/month/year boundaries and switched the CREATED-style formatters over. Avoids hand-editing vendor copies of go-units.Fixes #6891