Skip to content

Bump vitest to resolve vitest/vite security alerts - #96

Merged
dnegstad merged 1 commit into
mainfrom
claude/dependabot-fixes-82dy9k
Oct 27, 2026
Merged

dnegstad merged 1 commit into
mainfrom
claude/dependabot-fixes-82dy9k

Conversation

@dnegstad

Copy link
Copy Markdown
Owner

Requested by David · project thread

Summary

Bumps vitest from ^4.1.5 to ^4.1.12 in both extensions. This is a patch-level bump within 4.x that resolves:

The lockfile also drops the @rolldown/binding-wasm32-wasi optional chain, since the newer rolldown no longer declares it.

Note: the lockfile was regenerated with npm 11 because npm 10.9's arborist crashes (reading 'edgesOut') when updating this tree. npm ci with npm 10 against the new lockfile works.

Not resolved: @azure/msal-node (GHSA-xcx6-jx8p-x3h5, high)

Path: @vscode/vsce → @azure/identity@4.14.0 → @azure/msal-node@6.0.1. The only patched release is msal-node 7.0.3+, but @azure/identity still requires ^6.0.0 on both latest (4.14.0) and beta (4.15.0-beta.1), and vsce 4.0.0 is the newest vsce. Fixing it today would mean an overrides entry forcing a major version that identity doesn't declare support for. The advisory is about the authorization-code flow, and this repo only uses vsce package (no vsce publish / Azure credential auth), so the vulnerable code isn't reached.

Verification

  • npm audit: 3 high remaining, all the msal-node chain above (was 6: 4 high, 2 moderate)
  • npm run lint, all workspace typechecks, typecheck:e2e: pass
  • Unit tests: host 294 passed / 6 skipped; remote 113 passed / 1 skipped
  • npm run package for both extensions: OK

Generated by Claude Code

vitest 4.1.12 pulls a patched @vitest/mocker (GHSA-qxg6-89mg-rqv8,
GHSA-xp26-3454-mjgp) and lets vite resolve to 8.3.5, which fixes the
vite and bundled launch-editor advisories (GHSA-9jrq-w75r-8gcw,
GHSA-rq7h-c2jc-7f22, GHSA-698v-4r3x-3vcv, GHSA-r825-w8mm-5pxw,
GHSA-587h-7wmj-h5pm).

The @azure/msal-node advisory (GHSA-xcx6-jx8p-x3h5) is left open: the
fix is only in msal-node 7.x, and @azure/identity (via @vscode/vsce)
still pins ^6.0.0 on both latest and beta, so resolving it would mean
overriding a transitive dependency across a major version.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015KoYbz7ov9JGP4VsQDzSrX
@dnegstad dnegstad self-assigned this Oct 26, 2026
@dnegstad
dnegstad marked this pull request as ready for review October 27, 2026 06:26
@dnegstad
dnegstad merged commit 52f6275 into main Oct 27, 2026
9 checks passed
@dnegstad dnegstad mentioned this pull request Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants