Conversation
Author
|
Would be nice to get pushed in, after investigation this error is the cause of a Sentry alert we got in production: https://kvist.sentry.io/share/issue/7d30a4d50deb40ccb082dd57470640ab/ The alert is really random, and there no good traces because this library is a dependency in TipTap's dependency chain 👀 |
Author
|
@dmonad is this something that seems reasonable to add into a new release of lib0? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131.
When a browser exposes
localStoragebutgetItem()throws, the top-level environment flag checks can preventlib0/environmentfrom loading. Catch browser storage read failures ingetVariable()and returnnull, matching a missing flag. The Node environment-variable path is unchanged, and later successful storage reads still work.Adds tests to the existing runner for import-time
NS_ERROR_FAILURE/SecurityError, readable and missing values, temporary storage failure followed by recovery, and Node variable normalization. Browser initialization is exercised in isolated Node subprocesses with browser globals set before importing the real modules. The new failure tests fail against the previous implementation.The production report was on 0.2.117; this PR targets the current ESM-only
mainbranch.Validation:
node src/test.js --filter 'environment:'npm test(including coverage thresholds)npm run lint(JSDoc types, Standard style, circular imports)