attr.gi code coverage#919
Merged
mtorpey merged 4 commits intodigraphs:mainfrom Apr 22, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #919 +/- ##
==========================================
+ Coverage 97.37% 97.41% +0.03%
==========================================
Files 50 50
Lines 21179 21175 -4
Branches 639 639
==========================================
+ Hits 20623 20627 +4
+ Misses 491 483 -8
Partials 65 65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
james-d-mitchell
approved these changes
Apr 22, 2026
Member
james-d-mitchell
left a comment
There was a problem hiding this comment.
Nice, thanks @mtorpey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These PR fixes the four untested sections of code from attr.gi, some by adding tests, and some by amending the code.
The four commits are logically separate, so it might be better not to squash.
Code coverage of attr.gi should now be 100%.