Raise the native Windows browser-shell tests' timeout above the helper's 15s budget - #834
Merged
Merged
Conversation
Deploying mouseterm with
|
| Latest commit: |
594ec9e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://17810e71.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-ci-36500112814.mouseterm.pages.dev |
nedtwigg
requested a deployment
to
hosted-preview
September 29, 2026 04:33 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows leg of CI failed on main in run 36500112814 because
runs native PowerShell startup code and exitshit vitest's default 5s test timeout. This PR gives thenative Windows browser shellblock a 20s timeout. That is above the 15stimeoutMsthatbrowserLaunchEnvalready gives the shell, so the test allows as much time as production does.The test launches a real
powershell.exe. It passed in about 1.9s on the surrounding main runs (36500139090, 36498700094), and the next CI run on main passed without any change. The failure was a slow cold start on the runner, with no code regression behind it. The second error in the log,EBUSY ... rmdir 'dor launch spaces & …', follows from the timeout:afterEachtried to delete the temp dir while the abandoned PowerShell process still had it as its working directory.The test runs only on Windows and the sandbox had no network access to install dependencies, so this PR's
Standalone Platform Check (windows-latest)job is the verification.