fix(server): isolate rejected parallel history reads - #5115
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 4 Skipped Deployments
|
Contributor
|
Selected evidence: Incomplete · 12/12 tests · 18/18 assertions · 8 images Commit Coverage gaps: Required verification: incomplete. Selected evidence does not satisfy all required specs. No authenticated current-head required plan is available. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The V1 session proxy starts an upstream history read alongside its workspace-ownership proof. If the upstream transport rejects while that proof is still pending, the read has no rejection observer yet. This produces an unhandled rejection instead of keeping the failure scoped to the request. The concurrency path was introduced in #5075.
Change
The production change is one rejection observer plus an explanatory comment.
Validation
Focused local proxy checks: passed with Bun 1.3.14, synthetic workspaces, and a local mock engine:
/healthresponses.git diff --checkpassed.Scope and limitations
Hosted Web end-to-end proof is incomplete: no browser/Daytona run or deployment verification. The reproduced rejection bug is fixed, but it is not confirmed as the cause of a particular live outage. The test observes unhandled rejections in the test process; it is not proof of default-runtime process termination.
This does not change V2 routing, conversation storage/expiration, sandbox lifecycle, or frontend history-recovery behavior. No visual change; screenshots are not applicable.