fix(ci): fast-path verified clean reverts without review claims - #5109
benjaminshafii wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Selected evidence: Incomplete · 12/12 tests · 18/18 assertions · 8 images Commit Coverage gaps: Required verification: incomplete. Selected evidence does not satisfy all required specs. No authenticated current-head required plan is available. |
Warden review summary — ClearNative findings: 0. Blocking policy matches before consolidation: 0. Full finding text remains in Warden's native checks and review threads. This comment retains only native IDs, severity, skill attribution, and safe locations. Analysis run Reported trigger coverage (not proof of complete repository or context coverage): diff-security-review (152510 ms), confidentiality-review (192617 ms), spec-provenance-review (239125 ms). Blockers
Advisories
Needs recheck
Observed review-thread metrics
Thread states are read-only collection snapshots. These metrics are neither lifetime totals nor exact resolution times, and this summary is not clearance authority. |
Summary
devPRs with full immutable SHAs; current head/base and thedevtip are checked before and after Git tree verification. Titles/bodies are hints only.openwork-tests-requiredpublisher. Its verified-revert lane succeeds only with validated exemption output and all expected heavy jobs skipped. Normal lanes and non-PR routing remain unchanged.Verification on
0416daa642ac932e543a25098a9028b021a305ffnode --test scripts/ci/verify-clean-revert.test.mjsnode --test .github/scripts/warden-review.test.mjsnode --test scripts/ci/workflow-authoring-gate.test.mjsnode --test scripts/ci/ubuntu-apt-https.test.mjspnpm evals:pr specs/warden-review-lifecycle.test.tsgit diff --checkactionlint -ignore 'label "blacksmith-' -ignore 'SC2015:' -ignore 'SC2024:' .github/workflows/ci-tests.yml .github/workflows/revert-fastlane.yml .github/workflows/warden.yml .github/workflows/warden-clearance.ymlRaw
actionlinton those same four files exited 1: custom Blacksmith runner labels plus SC2015/SC2024 in the unchanged APT bootstrap. A pristine detached control at854695eb1677ead48c314bbefd4ff3f78eafa029reproduces the same six diagnostics (exit 1); only those diagnostics were filtered above. No repo-wide build was run.Earlier development reds: one new unit assertion expected an exception for an empty diff, but the preflight correctly returned ineligible before verification; fixed the assertion and reran. The first journey invocation exited 1 before tests because the separate
evalsworkspace was not installed;pnpm --dir evals install --frozen-lockfilefixed the environment. Root and evals frozen installs both exited 0.Full final local Warden: Incomplete — credentials required
Sole owner ran the exact unscoped
pnpm warden:checkafter committed-head journey verification. Exit 1,auth_failed; zero model tokens and no reviewed skill coverage. Do not interpret the CLI's zero findings as clearance.diff-security-review,confidentiality-review,spec-provenance-review.origin/dev...HEAD.0416daa642ac932e543a25098a9028b021a305ff.854695eb1677ead48c314bbefd4ff3f78eafa029.8e7b06dc-2026-09-17T14-26-55-694Z(private analysis log not published).WARDEN_OPENAI_API_KEYin the process environment or Infisicaldev, then the same bare command rerun with refs recorded. A name-only Infisical lookup found no Warden/OpenAI credentials indev.Rollout / limitations
This PR is ready for review, not asserted merge-ready. No merge, branch-rule change, admin bypass, global disabling, or duplicate success status was performed. Local tests cover routing and Git/API boundaries, not live GitHub execution. Trusted-base/default-branch helpers must land before an eligible revert can exercise the exemption. Validate the real fast lane after rollout; runner queues prevent any seconds-of-walltime guarantee.