Repository navigation
[release-0.5] fix(changelog): count fragments without the bad substitution that stopped the cut (#1655) - #1656
Merged
Merged
Conversation
…pped the cut (#1655) ${#fragments[@]:-0} is not valid bash, so changelog-fold.sh died after the merge on every dry run and every fold with a version, and cut-release.sh could not prepare v0.5.3-rc.1. Initialize the array once and count it plainly; --render leaves it empty and takes the else branch as before. (cherry picked from commit 6c1d6fa)
neochaotic
added
skip-changelog
Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Cherry-pick of #1655 (
git cherry-pick -x 6c1d6fa6) to release-0.5.scripts/changelog-fold.shdied on a bad substitution after the merge, which stoppedscripts/cut-release.sh v0.5.3-rc.1while preparing the release branch.How it was tested
On this branch:
bash scripts/changelog-fold.sh --self-testpasses (including the new end-to-end case), andscripts/changelog-fold.sh --dry-run 0.5.3-rc.1with changie v1.24.0 folds the 30 pending fragments and exits 0.Checklist
(cherry picked from commit ...)lineskip-changelogandskip-docs, as on fix(changelog): count fragments without the bad substitution that stopped the cut #1655Skip-docs: fixes a crash in the release tooling; no behavior users see changes.
Generated by Claude Code