Skip to content

#1956: Fix MAVEN_ARGS bug#2006

Open
laert-ll wants to merge 1 commit into
devonfw:mainfrom
laert-ll:bug/1956-merging-maven-args-buggy
Open

#1956: Fix MAVEN_ARGS bug#2006
laert-ll wants to merge 1 commit into
devonfw:mainfrom
laert-ll:bug/1956-merging-maven-args-buggy

Conversation

@laert-ll

@laert-ll laert-ll commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #1956

Implemented changes:

  • Extend mergeWithDefault method in AbstractEnvironmentVariables.java to account for the desired functionality.
  • Add new test case for this change.

Testing instructions

icd -p IDEasy
echo 'export MAVEN_ARGS="-Xmx8000m -s invalid/settings.xml -Dsettings.security=something_wrong"' >> conf/ide.properties
ide
echo $MAVEN_ARGS

Expected behavior:

-Xmx8000m -s D:\projects\IDEasy\conf\mvn\settings.xml -Dsettings.security=D:\projects\IDEasy\conf\mvn\settings-security.xml

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 27125044684

Coverage increased (+0.04%) to 71.092%

Details

  • Coverage increased (+0.04%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 1 78.33%

Coverage Stats

Coverage Status
Relevant Lines: 15833
Covered Lines: 11742
Line Coverage: 74.16%
Relevant Branches: 7074
Covered Branches: 4543
Branch Coverage: 64.22%
Branches in Coverage %: Yes
Coverage Strength: 3.14 hits per line

💛 - Coveralls

@laert-ll laert-ll marked this pull request as ready for review June 8, 2026 08:28
@laert-ll laert-ll self-assigned this Jun 8, 2026
@laert-ll laert-ll moved this from 🆕 New to Team Review in IDEasy board Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

Merging MAVEN_ARGS buggy

2 participants