Ship the tool as package id gh, invoked as dotnet gh - #3
Merged
Conversation
Member
Author
|
🧪 Details on Ubuntu 24.04.4 LTSfrom retest v1.1.0 on .NET 10.0.11 with 💜 by @devlooped |
dnx/ndnx gh uses the NuGet package id. ToolCommandName is dotnet-gh so a locally or globally installed tool is `dotnet gh` and does not replace GitHub's native `gh` on PATH. The tool project lives at src/gh. The repo and solution stay ghx. GitHub.Cli (pointer, RID payloads, GitHub.Cli.ResolvePath) is unchanged.
kzu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dnx/ndnx ghuses the NuGet package id. An installed tool isdotnet gh(ToolCommandNamedotnet-gh) so it does not replace GitHub's nativeghon PATH.What changed
PackageIdisgh; command isdotnet-gh(dotnet ghafterdotnet tool install gh)src/ghxtosrc/ghghx(devlooped/ghx,ghx.slnx)ghnupkgs; unix execute bits stampdotnet-ghand payloadghGitHub.Cli(pointer, RID payloads,GitHub.Cli.ResolvePath) is unchanged.