[follow-up] improve WebJS LID sends and failure diagnostics - #2190
Closed
shaqman wants to merge 1 commit into
Closed
[follow-up] improve WebJS LID sends and failure diagnostics#2190shaqman wants to merge 1 commit into
shaqman wants to merge 1 commit into
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2187\n\nThis is our follow-up contribution, authored and implemented by Syakur Rahman. It is intentionally separate from the cherry-picked base in companion PR #2189 for clear attribution.\n\nSummary:\n- Correct WebJS LID presence bridge selection and direct-contact sender behavior.\n- Wait for WhatsApp send acceptance before returning from send requests.\n- Preserve explicit WebJS message_ack values.\n- Expose bounded ackReason details for ACK_ERROR events.\n- Add structured failure logging without message content.\n- Add focused unit coverage.\n\nDependency order:\n- The separate whatsapp-web.js contribution is upstream PR https://github.com/devlikeapro/whatsapp-web.js/pull/2.\n- This WAHA branch currently pins shaqman/whatsapp-web.js#codex/pn-sender-for-lid-cold-contacts until that dependency change is accepted.\n- This follow-up also builds on WAHA cherry-pick PR #2189 for the initial WEBJS presence conversion.\n\nVerification: targeted WebJS tests passed; lint passed; build passed with polling due to the host inotify watcher limit.