Repository navigation
Conversation
The finally block read out.returncode even when run() had raised FileNotFoundError, so out was unbound. Use else instead, so the function returns None, and have CudaCompiler.std treat None as a pre-CUDA 13 toolkit.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3085.
get_cuda_versionreadout.returncodein afinallyblock. Whennvccisn't installed,runraisesFileNotFoundError, which is swallowed, and thenoutis unbound, so the function raisedUnboundLocalErrorinstead of returningNone. It now useselse.With that fixed,
CudaCompiler.stdwould fail next, withAttributeErroronNone.major. It now treats a missing version as pre-CUDA 13 and usesc++14, so code generation for the CUDA target without a toolchain works until compile time.Tests:
test_get_cuda_version_without_nvccandtest_cuda_std_without_nvccintests/test_arch.py. Both fail on main (UnboundLocalErrorandAttributeError) and pass with this change. I also ran the issue's repro with an empty PATH:get_cuda_version()now returnsNoneandCudaCompiler(...).stdgivesc++14. All 21 tests intests/test_arch.pypass andruff checkis clean.I didn't touch the caller in devitopro that the issue mentions, since it isn't in this repository.