Repository navigation
compiler: Include compiler settings in JIT cache keys - #3076
Merged
Merged
Conversation
Make Compiler a Signer using the effective compiler command and file extensions. Include it in the operator JIT digest so changes to flags or external library search paths produce distinct cache keys. Preserve option order and cover stable and distinct names with library-directory, CFLAGS, and LDFLAGS regressions.
mloubout
approved these changes
Oct 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3076 +/- ##
==========================================
+ Coverage 84.12% 84.13% +0.01%
==========================================
Files 258 258
Lines 57176 57205 +29
Branches 4887 4889 +2
==========================================
+ Hits 48098 48129 +31
+ Misses 8250 8249 -1
+ Partials 828 827 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
EdCaunt
reviewed
Oct 21, 2026
|
|
||
| operators = [] | ||
| for value in (*flags, flags[-1]): | ||
| monkeypatch.setenv(envvar, value) |
Contributor
There was a problem hiding this comment.
Can this be done without use of monkeypatch? We have switchenv for this right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Compiler a Signer using the effective compiler command and file extensions. Include it in the operator JIT digest so changes to flags or external library search paths produce distinct cache keys. Preserve option order and cover stable and distinct names with library-directory, CFLAGS, and LDFLAGS regressions.