chore(uiautomator2): remove escapeUIAutomatorString, which nothing calls any more - #200
Open
bulatgaleev wants to merge 1 commit into
Open
bulatgaleev wants to merge 1 commit into
bulatgaleev wants to merge 1 commit into
Conversation
…lls any more 30257df (Android device queries match the whole text and id) took out the last caller of this helper in the uiautomator2 driver. The unused linter has flagged it since, so Lint has failed on every push to main, and Build, which needs Lint, has been skipped each time. The same helper in the appium and devicelab drivers is untouched.
This was referenced Oct 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI has failed on every push to
mainsince 30257df ("Android device queries match the whole text and id"). That commit removed the last caller ofescapeUIAutomatorStringin the uiautomator2 driver, and golangci-lint'sunusedcheck has flagged it ever since:Lint is the only job that fails, and Build needs Lint, so Build is skipped on each of those runs. This removes the function.
Type of Change
Changes Made
escapeUIAutomatorStringand its comment frompkg/driver/uiautomator2/driver.go. Nothing else in the package calls it, tests included. The copies in the appium and devicelab drivers are untouched.Related Issues
No existing issue found.
Testing
go build ./...,go vet ./...andgo test -race ./pkg/driver/uiautomator2/...passmainatd3f738fit reports exactly this one issue; with this change it reports nonemake testas a whole: not run, because its device tests drive whatever device is attached to the machineChecklist
Additional Notes
#194 to #199 are stacked on this one, so that their Lint check passes as well. Merge this one first.
Stack 1 of 7: #200 → #194 → #195 → #196 → #197 → #198 → #199. Merge in that order. This is the base of the stack; its change is
352d9f5. All seven sit onmainatd3f738f(the merge of #185).