refactor(cloud)!: rename --ios-config/--android-config to --ios-devic…#77
Merged
Merged
Conversation
…e-matrix/--android-device-matrix (#1105) Aligns the flag names with the API's deviceMatrix field and says what they actually are. Clean break, no alias: the old names only ever existed in 5.2.0-beta.1 on the beta tag. citty silently ignores unknown flags, so a stale --ios-config would have been dropped and the run would have gone ahead on a single default device while the user believed a whole matrix ran — the exact silent under-testing this feature exists to prevent. Both removed names are therefore rejected explicitly, naming their replacement, covered by unit tests (incl. the --flag=value form).
The old --ios-config/--android-config names only ever existed in 5.2.0-beta.1, which nobody consumed, so there is no one to migrate. Guarding against them was dead code.
14 tasks
finalerock44
added a commit
that referenced
this pull request
Jul 13, 2026
…-matrix/--android-device-matrix (#77) Renames the device-matrix flags to match the API's `deviceMatrix` field and to say what they actually are (#1105). Clean break — no alias, no migration guard. The old names only ever existed in 5.2.0-beta.1, an unconsumed beta, so there is nobody to migrate. Deliberately NOT marked breaking. A `!` bumps the MAJOR on this 5.x repo (`bump-minor-pre-major` only applies below 1.0.0), which would ship a bogus 6.0.0 for renaming flags that nobody uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e-matrix/--android-device-matrix (#1105)
Aligns the flag names with the API's deviceMatrix field and says what they actually are. Clean break, no alias: the old names only ever existed in 5.2.0-beta.1 on the beta tag.
citty silently ignores unknown flags, so a stale --ios-config would have been dropped and the run would have gone ahead on a single default device while the user believed a whole matrix ran — the exact silent under-testing this feature exists to prevent. Both removed names are therefore rejected explicitly, naming their replacement, covered by unit tests (incl. the --flag=value form).
What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.