Skip to content

feat: guide visual inspection and keep answers focused - #218

Merged
devhims merged 1 commit into
mainfrom
feat/visual-inspection-workflow-main
Oct 20, 2026
Merged

devhims merged 1 commit into
mainfrom
feat/visual-inspection-workflow-main

Conversation

@devhims

@devhims devhims commented Oct 20, 2026

Copy link
Copy Markdown
Owner

Problem / Motivation

Visual questions lacked a consistent inspection workflow. Follow-up answers could confuse retrieved images with reported finding times or invent reasons for selecting frames. Ordinary answers could also include unnecessary narration about transcript reads and other tool use.

This replaces #213, which was reviewed against the PR #211 stack but merged into that stack's base branch instead of main after #211 landed. The change is identical to #213's final head (19194a2) and applies cleanly on top of #211 in main.

What changed

The visual-inspection skill guides locating subjects, using storyboard overviews, checking exact frames and reusing saved analysis. Frame requests record one basis category per timestamp, such as a spoken introduction or a storyboard overview, with the locating references it rests on. Free-text reasons are not accepted, so recorded selections carry no source content.

Structural records distinguish images supplied to analysts from timestamps mentioned in findings. Explicit workflow follow-ups use these records and identify unknown selection reasons. Ordinary answers present findings, citations and material uncertainty without unsolicited tool narration.

The separate semantic checker is removed entirely. Answers use existing schema and citation validation without a reviewer model call or duplicated reviewer prompt. Valid quote-only context and question memories are accepted without generated text.

The retained answer path uses the new inspection context:

%%{init: {'theme': 'base', 'themeVariables': {'actorBkg': '#e8eef6', 'actorTextColor': '#172b4d', 'actorBorder': '#52657a', 'signalColor': '#52657a', 'signalTextColor': '#52657a', 'labelBoxBkgColor': '#172b4d', 'labelTextColor': '#ffffff', 'sequenceNumberColor': '#ffffff'}}}%%
sequenceDiagram
    autonumber
    participant R as Research agent
    participant F as Finalizer (retained)
    participant S as Storage (retained)
    R->>F: Supply analyzed evidence and recorded inspection context
    F->>S: Save after structure and citation validation
    S->>S: Update quoted user memory separately
Loading

Tests

Platform build passed. Repository tests: 2,599 passed, 58 skipped. Separate auth integration: 170 passed. Regressions verify single-call finalization and retained history and memory behavior.

Live Fireworks replay passed all four original questions, with direct initial prose, working workflow follow-ups and no inspection reviewer calls. Replay used saved public assets and local SQLite.

Production rollout remains pending. Image interpretation and answer style depend on model behavior. Existing memory is not backfilled. Workflow and replay notes.

Reviewed and tested as #213, which merged into its stacked base branch instead of main after #211 landed. This applies the same change to main unchanged.
@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
video2ctx-web Ready Ready Preview Oct 20, 2026 4:21pm UTC

devhims commented Oct 20, 2026

Copy link
Copy Markdown
Owner Author

Independent review — e84c4c0

Verdict: APPROVE this exact head against main 677f9117afd41d769837ef195190612621a36666. No material source finding remains.

Retarget verified

This is an exact source-tree transfer of reviewed PR213, not a new implementation or conflict resolution. Head e84c4c0 and reviewed head19194a2 share tree 4f6590018582a801cd949cee01740ff02cbaeaba. Main/base677f9117 and previously reviewed base48c27b8 share tree 2df1d9ed91fb664de33bb506389406d1af59776e. The effective26-file diff is identical; PR211 is now in main.

The prior correctness fixes remain intact: fixed frame-selection categories strip free-text reasons; locating references require delivered evidence from the same video; inspection history stays branch-scoped; quote-only user memories retain the user's words. Existing review: #213 (comment)

P3 — Combined analysis operation labels remain inconsistent (nonblocking)

platform/src/agents/runtime/inspection-records.ts:43 still calls evidenceDeliveryOperation(record) without packet artifact types. Combined get_video_frames analysis can show operationThisTurn=retrieval alongside savedRecord=analysis and inputMeaning confirming analyst inputs. Ordinary admitted-evidence labels correctly identify image_analysis. Pass artifact types here as finalizationEvidenceForModel does.

This is the unchanged consistency finding, not evidence of lost analysis, incorrect billing or a demonstrated live-answer failure. Other structural fields retain the analysis proof.

Verification

Fresh on this head:

  • Five focused suites: 57 passed, covering inspection records, frames, memory updates, answer finalization and model evidence.
  • Platform TypeScript, generated-skill/documentation checks and full-diff whitespace checks passed. Initial TypeScript invocation lacked restored workspace-package dependencies; linking existing lockfile-matched dependencies and rerunning succeeded without source changes.
  • Verify CI39456619769 succeeded, including both dashboard E2E groups, Auth E2E, platform checks/integration, Web, Documentation and Library.

Historical, not rerun here: the identical tree passed 2,916 standard tests, 61 skipped, plus nine independent probes. These are not added to today's57.

Limits

Approval is source/CI approval, not confirmation of production rollout or model behavior. No live-provider replay was performed in this re-review. Separate current-production browser tests are not established as running this head and must not be used to claim its fixes passed or failed. Structural tests do not guarantee image interpretation or answer style. Skipped cases remain unverified; no new Kiro alignment is claimed. No implementation, push, merge, deployment or repository settings change performed.

@devhims
devhims merged commit 265f858 into main Oct 20, 2026
10 checks passed
@devhims
devhims deleted the feat/visual-inspection-workflow-main branch October 20, 2026 16:36

This branch was successfully deployed

1 active deployment
Preview — e84c4c07 Deployed Oct 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant