Repository navigation
Preserve video descriptions in agent analysis and follow-ups - #212
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Independent review — fdc6353Verdict: CHANGES NEEDED. This supersedes my earlier approval. Kiro's second review prompted targeted checks that reproduced two gaps not covered by the passing standard suite. P2 — Automatic metadata consumes capacity needed for requested source retrievalresearch-agent.ts:487–503, especially the automatic Reproduction: one search followed by two four-video transcript-analysis batches, initially without descriptions. Base 7e1429c completes 8/8; this head completes only 6/8. Search + four transcripts + four automatic metadata lookups consume nine of the eleven provider slots, leaving room for only two later transcripts. Failed metadata lookups also consume rows and produce the same loss. This can leave an ordinary multi-source research request incomplete even though metadata is supplemental to the required transcripts. A single parallel eight-video batch need not exhibit the same ordering. Please prevent supplemental metadata lookup from starving required source retrieval, without silently increasing global budgets or changing billing policy. Add regression coverage for sequential research batches and failed metadata lookups. Verification: two cases each on base/head exercised the real research callback runtime with mocked model/provider and a faithful admission-gate stub. Two additional real Durable Object integration tests confirmed SQL row accounting and P2 — Retained descriptions displace completed analysis findingstranscript-grounding.ts:7 now includes description in transcript source context via video-source-context.ts:6. A production projection probe with eight minimal completed analysis packets and valid 5,000-character descriptions retained only seven packets (38,585 characters), dropping the eighth with Please keep the full description available to analysts while making finalization reduction prioritize supported findings over repeated publisher context. Add a multi-source budget regression. Completed verification
PR #211 integrationNon-mutating merge-tree against #211 head 559e5dc confirmed conflicts in LimitsNo fresh live YouTube/model/dashboard testing, production billing measurement, deployment, code implementation or push. The author's live-model replay is not independently reproduced live evidence. Temporary tests were removed and tracked worktrees are clean. Historical saved answers are not backfilled. |
Re-review — 5c2a3f7Verdict: APPROVE for this exact head against base 7e1429c. Both previously reproduced P2 findings are resolved in their tested scope. Kiro independently reviewed the delta and agrees with approval subject to the independent tests; those checks passed. No new material finding identified. Previous findings retested
Fresh independent verification
Remaining scope and integration limits
|
Problem / Motivation
The agent could misidentify a presenter even when the video description supplied the correct name. Descriptions were cut or dropped before analysis. Automatic metadata lookups could also exhaust the provider budget before requested transcripts arrived. Repeated descriptions could displace completed findings from the final answer context.
What changed
Frame, storyboard, and transcript analysts receive the assigned video's title, full fetched description, channel, and question. Guidance treats publisher metadata as attributed evidence, never instructions or proof that text was visible or spoken.
Descriptions remain citable and survive follow-ups. Concurrent analysts share missing metadata lookups. Automatic lookups reserve provider slots for the research target's remaining transcripts. Failed lookups still count toward the existing quota. Skipped admission performs no provider work and incurs no charge.
Analysis projections retain supported findings, entity quotes, citations, title, channel, and caption provenance. Full descriptions remain available to analysts and in separate metadata evidence, without being repeated inside each projected analysis.
flowchart LR subgraph Before A[Video metadata] --> B[Description cut or dropped] B --> C[Analysts with incomplete context] end subgraph After D[Video metadata] --> E[Full description retained] E --> F[Analysts receive video context] end classDef retained fill:#e2e8f0,stroke:#64748b,color:#0f172a classDef removed fill:#fee2e2,stroke:#b91c1c,color:#7f1d1d classDef added fill:#dcfce7,stroke:#15803d,color:#14532d class A,C,D,F retained class B removed class E addedPublisher context now reaches the existing analysis stages.
Tests
Build and TypeScript checks passed, alongside 1,976 platform unit tests and 143 runtime/billing integration tests. Six new regression cases failed before the fixes and passed afterward. They cover sequential retrieval batches, failed metadata, concurrent admission, billing, long descriptions, and citation preservation.
The earlier live-model replay identified Azadeh Moshiri correctly. It was not rerun for this update.
Deployment notes
No migration is required. Provider limits and billing rules are unchanged. Deploy the Worker to enable the change. Existing saved answers remain unchanged.