fix(a11y): keep summary above scrolled violations - #351
Open
SaKaNa-Y wants to merge 1 commit into
Open
Conversation
◈ PR Lens
Architecture 1 component touched across 4 lanes. Data flow No data-flow sequence changed in this PR. Drill down
|
|
@SaKaNa-Y is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In a short A11y Inspector dock, scrolling the violation list could paint violation rows over the sticky summary controls. This left the summary partially visible but made its lower actions inaccessible.
Cause
The summary used
z-[2], but the shared@antfu/designUnoCSS preset blocks unnamed numeric z-index utilities. The class therefore produced no z-index rule, allowing later positioned violation rows to paint above the sticky summary.Fix
Use the shared
z-navlayer for the sticky summary. Add a 360px-height regression test that scrolls the panel, verifies every summary button remains the pointer hit target, and confirms a severity filter is still interactive.Verification
pnpm lintpnpm knippnpm typecheck— 39/39 tasks passedpnpm test— 128 files passed; 1,453 tests passed and 9 skipped; no type errorspnpm build— 27/27 tasks passedpnpm exec playwright test --config .tmp-playwright.config.ts tests/e2e/a11y-messages-hub-static.spec.ts— 4/4 tests passed using the installed system Chrome