fix(docs): upgrade comark-docs and fix logo layout shift - #330
Merged
Conversation
Written by an AI agent on behalf of @atinux, who supplied and reviewed this message.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the docs site configuration and upstream comark-docs patching to eliminate the header logo layout shift and restore expected logo interactions, while aligning workspace trust-policy exclusions with updated transitive dependencies.
Changes:
- Switch the docs header logo configuration to use
logo.markand introduce a dedicatedLogoMark.vueSVG component. - Update the
comark-docspatch to use Shiki (with Vitesse themes) instead of Rangi/Geist theme wiring. - Extend pnpm trust-policy exclusions for updated
@vercel/*dependency versions.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pnpm-workspace.yaml |
Adds additional trustPolicyExclude entries to accommodate updated @vercel/* dependency versions. |
patches/comark-docs@0.0.1.patch |
Adjusts upstream comark-docs to use Shiki-based highlighting with Vitesse themes. |
docs/app/components/LogoMark.vue |
Adds an inline SVG logo mark component used by the docs header. |
docs/app/app.config.ts |
Switches docs header logo config from light/dark URLs to mark: 'devframe'. |
Suppressed comments (1)
pnpm-workspace.yaml:40
trustPolicyExcludeincludes@vercel/cli-config@0.2.3, but the lockfile resolves@vercel/cli-config@0.2.4. To keep the trust exclusions narrowly scoped (and reduce future drift), it’s better to remove the unused version entry.
- '@vercel/cli-config@0.2.3'
- '@vercel/cli-config@0.2.4'
- '@vercel/cli-exec@1.0.1'
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
33
to
+37
| - tinyexec@1.2.2 | ||
| - '@vercel/functions@3.9.3' | ||
| - '@vercel/functions@3.9.5' | ||
| - '@vercel/oidc@3.8.4' | ||
| - '@vercel/oidc@3.8.5' |
| </script> | ||
|
|
||
| <template> | ||
| <svg class="h-6 w-auto" viewBox="0 0 500 500" fill="none" xmlns="http://www.w3.org/2000/svg"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by an AI agent on behalf of @atinux, who supplied and reviewed this title and description.
I noticed an issue on current website for the logo, the best way is to use the logo.mark feature and use the LogoMark.vue component. I also upgraded comark-docs so the right click on the logo now works.