fix: create parent directories for nested clonePath

[snecklifter]

Summary

• When a devfile project specifies a nested clonePath (e.g. back/devfile-rest), os.Rename fails because the intermediary parent directories don't exist
• Adds os.MkdirAll(path.Dir(...)) calls before os.Rename in both the git and zip project setup paths to ensure parent directories are created
• For flat clonePath values, path.Dir resolves to the already-existing root so MkdirAll is a no-op

Fixes: eclipse-che/che#23877

Test plan

• Start a workspace with a devfile containing multiple projects with nested clonePath values (e.g. back/devfile-rest, ui/devfile-ui)
• Verify all projects are cloned into the correct subdirectory structure under /projects
• Verify single-level clonePath values still work as before

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Projects can now be successfully cloned into deeply nested destination paths without requiring manual parent directory creation, improving workflow flexibility for complex project structures.

• Tests

  • Added comprehensive test coverage for nested clone path scenarios, verifying both git and zip-based project cloning into multiple directory levels.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: snecklifter
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @snecklifter. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 711a1434-30e0-40c9-9758-0eb3caaefcbe

📥 Commits

Reviewing files that changed from the base of the PR and between cdc8050 and 437833d.

📒 Files selected for processing (3)

• project-clone/internal/git/setup.go
• project-clone/internal/zip/setup.go
• project-clone/test/nested-clone-path-test.devworkspace.yaml

---

📝 Walkthrough

Walkthrough

Adds os.MkdirAll calls in the git (doInitialGitClone, copyProjectFromTmpDir) and zip (SetupZipProject) project-clone setup paths to create intermediate parent directories before temporary clone paths and final destination paths are used. A new DevWorkspace YAML integration test validates nested clonePath scenarios.

Changes

Parent Directory Creation Fix with Integration Test

Layer / File(s)	Summary
MkdirAll in git and zip setup before clone and rename project-clone/internal/git/setup.go, project-clone/internal/zip/setup.go	doInitialGitClone creates the parent of tmpClonePath via os.MkdirAll before cloning. copyProjectFromTmpDir creates the parent of projectPath before any rename, and the subdir branch is updated to use the precomputed projectPath with an added log line. SetupZipProject adds os.MkdirAll for both the temporary extraction path and the final projectPath before renaming, wrapping errors on failure.
Integration test: nested clonePath DevWorkspace manifest project-clone/test/nested-clone-path-test.devworkspace.yaml	New ephemeral DevWorkspace manifest clones four git projects into nested (back/api, back/worker, ui/app) and flat (flat-project) clonePath locations. An inline bash script validates directory existence, default_branch_name checkout, and origin remote URL for each cloned project.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 Hop hop, the path must be there,
Before we clone into the air!
MkdirAll clears the way,
Nested folders here to stay.
No more errors, hip hooray! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: adding directory creation for nested clonePath specifications.
Linked Issues check	✅ Passed	The PR fully addresses the linked issue #23877 by adding os.MkdirAll calls in git and zip setup code to create parent directories before rename operations.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the nested clonePath issue: two setup files implement the fix and one test file validates it.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[dkwon17]

Thank you @snecklifter LGTM, could you please add some tests in https://github.com/devfile/devworkspace-operator/tree/main/project-clone/test?

[snecklifter]

Thanks @dkwon17 — I've added an integration test fixture at project-clone/test/nested-clone-path-test.devworkspace.yaml that covers nested clonePath with multiple projects sharing intermediary directories, plus a flat project to ensure no regression. Squashed into a single commit.