Skip to content

ci: keep each main run from being cancelled by the next merge - #83

Merged
devantler merged 1 commit into
mainfrom
claude/ci-main-concurrency-2690
Sep 22, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/ci-main-concurrency-2690

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

When two changes land on the main branch close together, the second one cancels the checks still running for the first, and a cancelled check does not count as a failure. So main can show green for a change that was never fully checked.

What

Every change landing on main now gets its own check run that later merges cannot cancel or push out of the queue. Checks on pull requests still drop superseded runs as before. This is the last repository from a portfolio-wide sweep; the other four were fixed earlier.

Fixes #82

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

@devantler: I will perform a full review of #83.

✅ Action performed

Full review finished.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 98f1ddb0-7718-48aa-9715-bf2827d73446

📥 Commits

Reviewing files that changed from the base of the PR and between 05030b7 and 76f2e89.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
🔇 Additional comments (1)
.github/workflows/ci.yml (1)

11-16: LGTM!


📝 Walkthrough

Walkthrough

The CI workflow now assigns each main run a group based on github.run_id and does not cancel in-progress main runs. Other refs continue to use ref-based groups with cancellation enabled. Previously, all refs used ref-based groups and cancellation was always enabled.

Priority: ➖ Normal

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 76f2e

Main-branch checks are protected from later merges, while pull-request checks still cancel superseded runs. The change is merge-ready.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Issue #82 requires independent concurrency for pushes to main and cancellation for superseded pull request runs. In .github/workflows/ci.yml, main uses github.run_id in the concurrency group a…
Out of Scope Changes check ✅ Passed The reviewed change is limited to the CI concurrency declaration and its explanatory comments. It directly supports Issue #82. No unrelated implementation, workflow job, or repository change is shown.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Title check ✅ Passed The title clearly summarizes the main CI concurrency change: preventing later merges from cancelling checks for runs on main.
Description check ✅ Passed The description directly explains the CI cancellation problem and the change that preserves independent main-branch checks while retaining pull request cancellation.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Evaluation at 76f2e89f79b5acddabef3fd0faeb67787fd2ddc6

  • Review: the CodeRabbit full review is green at this head, and the verdict helper returns GREEN. CI passed: 14 checks succeeded and 2 were skipped.
  • Behaviour:

@devantler
devantler marked this pull request as ready for review September 22, 2026 12:42
@devantler
devantler merged commit bc4ffbf into main Sep 22, 2026
16 checks passed
@devantler
devantler deleted the claude/ci-main-concurrency-2690 branch September 22, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI on main can be cancelled by the next merge

1 participant