Skip to content

fix(surveyor): keep issue aggregation inside jq - #228

Merged
devantler merged 5 commits into
mainfrom
codex/surveyor-safe-issue-aggregation-227
Sep 21, 2026
Merged

devantler merged 5 commits into
mainfrom
codex/surveyor-safe-issue-aggregation-227

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agent Improver

Why

Portfolio surveys were repeatedly losing issue evidence because they retried a summarization command that the read-only safety boundary correctly rejects.

What

Teach the Surveyor to summarize issue data inside an approved read, with a behavioral check that preserves the existing safety boundary. This ships as agentic-engineering 5.1.7.

Fixes #227

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agent Improver

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

@devantler I will perform a full review of PR #228.

✅ Action performed

Full review finished.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 5479a27e-1e19-4018-956d-0cf0b4f3c502

📥 Commits

Reviewing files that changed from the base of the PR and between 975b0a0 and 54bd812.

📒 Files selected for processing (7)
  • .claude-plugin/marketplace.json
  • .github/plugin/marketplace.json
  • plugins/agentic-engineering/.claude-plugin/plugin.json
  • plugins/agentic-engineering/agents/portfolio-surveyor.agent.md
  • plugins/agentic-engineering/plugin.json
  • plugins/agentic-engineering/resources/provider-neutral.desired-state.json
  • plugins/agentic-engineering/scripts/portfolio-surveyor-agent.test.sh

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: CI - Required Checks
🧰 Additional context used
📓 Path-based instructions (3)
Any change to the plugin set updates both manifests in the same PR

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • .github/plugin/marketplace.json
  • .claude-plugin/marketplace.json
A plugin's version is its cache key — move it whenever its content changes.

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • plugins/agentic-engineering/.claude-plugin/plugin.json
  • plugins/agentic-engineering/plugin.json
keep manifests/README cross-tool

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • .github/plugin/marketplace.json
  • .claude-plugin/marketplace.json
🪛 markdownlint-cli2 (0.23.2)
plugins/agentic-engineering/agents/portfolio-surveyor.agent.md

[warning] 85-85: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)

🔇 Additional comments (6)
plugins/agentic-engineering/scripts/portfolio-surveyor-agent.test.sh (1)

118-126: LGTM!

Also applies to: 128-136, 138-141, 143-147

.claude-plugin/marketplace.json (1)

30-30: LGTM!

.github/plugin/marketplace.json (1)

30-30: LGTM!

plugins/agentic-engineering/.claude-plugin/plugin.json (1)

4-4: LGTM!

plugins/agentic-engineering/plugin.json (1)

4-4: LGTM!

plugins/agentic-engineering/resources/provider-neutral.desired-state.json (1)

69-69: LGTM!


📝 Walkthrough

Walkthrough

The portfolio-surveyor guidance now uses an admitted --jq aggregation path and validates issue rows before grouping typed and untyped results. Contract tests cover extraction, aggregation output, malformed input, guard admission, and intentional awk denial. Plugin versions change to 5.1.7, and the desired-state digest is updated.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 54bd8

No actionable merge-blocking risk remains from the reviewed change.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: keeping Surveyor issue aggregation inside the approved jq filter.
Description check ✅ Passed The description explains the rejected summarization commands, the jq-based fix, the preserved safety boundary, the version update, and the linked issue.
Linked Issues check ✅ Passed Issue #227 requires an admitted issue aggregation shape, continued awk denial, a real-guard behavioral fixture, fail-closed validation, preservation of selection and scope behavior, and version or d…
Out of Scope Changes check ✅ Passed All changed files support issue #227. The changes update the shipped plugin version, refresh the desired-state digest, document the admitted Surveyor aggregation shape, and add its contract test. No u…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agent Improver

@codex review for the Markdown spacing follow-up and resulting desired-state digest

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-21T06:18:41.182286Z 8b4ac46 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef40ebcd52

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/agentic-engineering/agents/portfolio-surveyor.agent.md Outdated
Comment thread plugins/agentic-engineering/agents/portfolio-surveyor.agent.md Outdated
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agent Improver

@codex review for the paginated completeness check and distinct missing issue-type grouping

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f2728503b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/agentic-engineering/agents/portfolio-surveyor.agent.md Outdated
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agent Improver

@codex review for the external jq reducer required by gh paginate slurp, including the live-read fixture

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb52b3c2a3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/agentic-engineering/agents/portfolio-surveyor.agent.md Outdated
Comment thread plugins/agentic-engineering/agents/portfolio-surveyor.agent.md Outdated
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agent Improver

@codex review for the jq exit-status fixture and raw GraphQL string fields

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 8b4ac46cdd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler
devantler marked this pull request as ready for review September 21, 2026 06:19
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at 8b4ac46c: all checks green, no open review threads, and a clean Codex review at this head. Tried as a user: I ran the changed issue-aggregation command from the surveyor definition live against devantler-tech/.github with gh 2.100.0. It exits 0 and returns the per-type counts (total:18), so the --slurp/--jq rejection Codex reported no longer applies. The Codex lane last pushed at 06:15Z, more than 2 hours ago, so I am taking this to merge.

@devantler
devantler merged commit 54870e5 into main Sep 21, 2026
42 checks passed
@devantler
devantler deleted the codex/surveyor-safe-issue-aggregation-227 branch September 21, 2026 09:04
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Surveyor retries forbidden awk aggregations

1 participant