Skip to content

test: read the embed provider list even when parallel workers inherit it #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GTS-MEGHNI wants to merge 1 commit into from
Closed

test: read the embed provider list even when parallel workers inherit it #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions tests/Unit/Services/EmbedsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use App\Enums\EmbedKind;
use App\Services\EmbedProviders\YouTube;
use App\Services\Embeds;
use Illuminate\Support\Env;
use Dotenv\Repository\RepositoryBuilder;
use Uri\WhatWg\Url;

it('embeds links to a provider', function (): void {
Expand Down Expand Up @@ -63,9 +63,16 @@ public function embed(Url $url): Embed
});

it('reads the provider list from the environment', function (): void {
Env::getRepository()->set('EMBEDS_PROVIDERS', ' youtube, ,spotify ');
$config = require config_path('embeds.php');
Env::getRepository()->clear('EMBEDS_PROVIDERS');
// Parallel workers inherit EMBEDS_PROVIDERS from .env, and Laravel's repository never overwrites a variable that is already set.
$repository = RepositoryBuilder::createWithDefaultAdapters()->make();
$original = $repository->get('EMBEDS_PROVIDERS');

try {
$repository->set('EMBEDS_PROVIDERS', ' youtube, ,spotify ');
$config = require config_path('embeds.php');
} finally {
$original === null ? $repository->clear('EMBEDS_PROVIDERS') : $repository->set('EMBEDS_PROVIDERS', $original);
}

expect($config['only'])->toBe(['youtube', 'spotify']);
});
Loading