Repository navigation
docs: add commit now and going live during a timeout to the knowledge base - #1212
sulimanbenhalim wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Commit now documentation KNOWLEDGE_BASE.md |
The scheduled-commits page documents the Commit now action and states that it shares the 10-per-minute limit with scheduling. |
Timeout documentation
| Layer / File(s) | Summary |
|---|---|
Timeout restrictions KNOWLEDGE_BASE.md |
The timeout restriction list includes going live and clarifies that an existing stream can remain live and be ended. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Possibly related PRs
- dev-null-sh/dev-null.sh#1136: Adds the Commit now action and its submission route, which the knowledge base documents.
Suggested reviewers: xheaven
Merge Risk: 
Minimal · up to a8ee0
-
The knowledge-base updates accurately describe Commit now limits and timeout behavior; no merge-blocking risk is identified.
Architecture risk: 
Low · up to a8ee0
-
The change affects 1 system.
Changed systems:
KNOWLEDGE_BASE.mdArchitecture concerns
No architecture-level concerns identified.Review details
-
Systems and components
- observed — KNOWLEDGE_BASE.md (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
- observed — Modified behavior in KNOWLEDGE_BASE.md: The scheduled-commits page now offers Commit now for queued posts, and the documentation states that immediate submission shares the 10-per-minute limit. The existing scheduling interval, outstanding limit, and scheduler behavior remain documented.
- observed — Modified behavior in KNOWLEDGE_BASE.md: Timeout restrictions now include going live, while explicitly allowing an existing stream to remain live and be ended. The old restriction list did not mention going live.
-
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Summary
KNOWLEDGE_BASE.mdso Tom still answers from the old textChanges
ScheduledCommitSubmissionController.phpValidation
scheduled-commit-submission.storesubmits the queued commit into the usual review process behindThrottleCommitsandPreventPostingInTimeoutwhileuser-live.updatehasPreventPostingInTimeoutanduser-live.destroydoesn't andCreateUserTimeoutnever ends a streamKNOWLEDGE_BASE.mdwhich no test reads and lint still passesbun run test:unithas one failure that production already has since80cca8f4(fix: pooling)Independent review
e83d7c04heada8ee050fchecking each sentence against the controllers and middleware and testsLimitations
Summary by CodeRabbit