Skip to content

docs: add commit now and going live during a timeout to the knowledge base - #1212

Open
sulimanbenhalim wants to merge 1 commit into
dev-null-sh:productionfrom
sulimanbenhalim:docs/kb-commit-now-and-live
Open

sulimanbenhalim wants to merge 1 commit into
dev-null-sh:productionfrom
sulimanbenhalim:docs/kb-commit-now-and-live

Conversation

@sulimanbenhalim

@sulimanbenhalim sulimanbenhalim commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Changes

  • the scheduled commits paragraph says a queued post can be canceled or submitted right away with Commit now which counts against the same 10 per minute limit and its sources link ScheduledCommitSubmissionController.php
  • the timeout paragraph lists going live with the other things a timeout blocks and says a stream that is already live keeps showing and End stream still works

Validation

  • checked against the code and the tests of feat: commit a scheduled commit now #1136 and fix: stop people in timeout from going live #1146: scheduled-commit-submission.store submits the queued commit into the usual review process behind ThrottleCommits and PreventPostingInTimeout while user-live.update has PreventPostingInTimeout and user-live.destroy doesn't and CreateUserTimeout never ends a stream
  • the full gate passed on the first revision (4529 tests with 100% coverage) and the final one only adds two sentences to KNOWLEDGE_BASE.md which no test reads and lint still passes
  • bun run test:unit has one failure that production already has since 80cca8f4 (fix: pooling)

Independent review

  • read-only Claude agent: CODE PASS on base e83d7c04 head a8ee050f checking each sentence against the controllers and middleware and tests

Limitations

  • None

Summary by CodeRabbit

  • New Features
    • Scheduled commits can now be submitted immediately using Commit now.
  • Behavior Changes
    • Immediate commits share the scheduling limit of 10 per minute.
    • Going live is blocked during a timeout; ending an active stream remains allowed.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3bf971b7-df67-4af7-8be9-268c42722007
Commits

Reviewing files that changed from the base of the PR and between e83d7c0 and a8ee050.

Files selected for processing: 1
  • KNOWLEDGE_BASE.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

The knowledge base now describes immediate submission for scheduled commits, including its rate limit. It also documents timeout restrictions on going live and ending an existing stream.

Changes: Scheduled commit documentation

Layer / File(s) Summary
Commit now documentation
KNOWLEDGE_BASE.md
The scheduled-commits page documents the Commit now action and states that it shares the 10-per-minute limit with scheduling.

Timeout documentation

Layer / File(s) Summary
Timeout restrictions
KNOWLEDGE_BASE.md
The timeout restriction list includes going live and clarifies that an existing stream can remain live and be ended.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

Suggested reviewers: xheaven

Merge Risk: Minimal · up to a8ee0

The knowledge-base updates accurately describe Commit now limits and timeout behavior; no merge-blocking risk is identified.

Architecture risk: Low · up to a8ee0

The change affects 1 system.

Changed systems: KNOWLEDGE_BASE.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — KNOWLEDGE_BASE.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in KNOWLEDGE_BASE.md: The scheduled-commits page now offers Commit now for queued posts, and the documentation states that immediate submission shares the 10-per-minute limit. The existing scheduling interval, outstanding limit, and scheduler behavior remain documented.
  • observed — Modified behavior in KNOWLEDGE_BASE.md: Timeout restrictions now include going live, while explicitly allowing an existing stream to remain live and be ended. The old restriction list did not mention going live.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the documentation changes for Commit now and going live during a timeout. It matches the main changes in the pull request.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant