Repository navigation
fix: keep the vote and undo buttons the same width while they work - #1211
sulimanbenhalim wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Set button minimum widths resources/js/components/commit-poll.tsx, resources/js/components/commit-undo-toast.tsx |
The Vote button uses min-w-19. The undo button uses min-w-30. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Possibly related PRs
- dev-null-sh/dev-null.sh#1207: Adds a minimum width to a button to keep its layout stable when its label changes.
Suggested reviewers: xheaven
Merge Risk: 
Minimal · up to 44935
-
The scoped presentation change introduces no actionable merge-blocking risk.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 2 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Summary
Voting…andRestoring…while their request runs and grow to fit it so the button jumps left by 21px and 40pxChanges
min-w-19on the poll's Vote button andmin-w-30on the Undo button in the deleted commit toast75.2pxand119.1px)Validation
bun run test:unithas one failure that production already has since80cca8f4(fix: pooling) and it fails the same way without this change20.8pxand39.7pxand Vote logged alayout-shifteach timelayout-shiftVisual evidence
each image is the button at rest on top and while its request runs below
Device verification
Independent review
e83d7c04head4493598bafter a VISUAL FAIL round that caught Reply and Quote wrapping at rest on 390px and 375px phones so they were taken outLimitations
Replying…orQuoting…makes them wrap at rest in their footers on 390px and 375px phonesSummary by CodeRabbit