Skip to content

feat: make stargazers have a hovercard - #1204

Open
sulimanbenhalim wants to merge 1 commit into
dev-null-sh:productionfrom
sulimanbenhalim:feat/stargazers-hovercards
Open

sulimanbenhalim wants to merge 1 commit into
dev-null-sh:productionfrom
sulimanbenhalim:feat/stargazers-hovercards

Conversation

@sulimanbenhalim

@sulimanbenhalim sulimanbenhalim commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Changes

  • commit-stargazers-dialog.tsx wraps each row in UserPreview the way changelog-lane.tsx does inside its dialog
  • the card only loads when you hover a row like everywhere else so the dialog itself costs nothing more

Validation

  • lint types JS tests and build pass locally plus the full pest suite with 100% coverage (4529 tests)
  • opened the dialog as the author and hovered a row locally at 1440x900 and at 1366x650 where the card flips above a lower row in light and dark

Visual evidence

before after

Device verification

  • desktop chrome only since UserPreview opens for a mouse pointer and touch stays the same

Independent review

  • read-only Claude agent: CODE PASS and VISUAL PASS on base 75c969e1 head b80015c9 after a VISUAL FAIL round that asked for the 1366x650 captures

Limitations

  • None

Summary by CodeRabbit

  • New Features
    • Stargazer profiles now include user previews while retaining the existing profile links, avatars, names, and handles.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b16cbd5f-c967-4459-ba8c-67f8d579c0fb
Commits

Reviewing files that changed from the base of the PR and between 75c969e and b80015c.

Files selected for processing: 1
  • resources/js/components/commit-stargazers-dialog.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

The stargazer dialog now wraps each stargazer’s existing profile link and display in UserPreview. The link destination, close-on-click behavior, avatar, name, and handle remain unchanged.

Changes: Stargazer previews

Layer / File(s) Summary
Wrap stargazer links in UserPreview
resources/js/components/commit-stargazers-dialog.tsx
The dialog imports UserPreview and wraps each stargazer’s existing profile link and contents. It passes the stargazer as the user and applies block styling.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Possibly related PRs

Suggested reviewers: hbenabdallah

Merge Risk: Minimal · up to b8001

The hovercard enhancement does not present an identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adding hovercards to stargazers.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant