Repository navigation
feat: make stargazers have a hovercard - #1204
Open
sulimanbenhalim wants to merge 1 commit into
Open
sulimanbenhalim wants to merge 1 commit into
sulimanbenhalim wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Wrap stargazer links in UserPreview resources/js/components/commit-stargazers-dialog.tsx |
The dialog imports UserPreview and wraps each stargazer’s existing profile link and contents. It passes the stargazer as the user and applies block styling. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Feature
Possibly related PRs
- dev-null-sh/dev-null.sh#1156: Changes the
UserPreviewcontract to accepthandle, which this change uses. - dev-null-sh/dev-null.sh#128: Adds
UserPreviewto a user profile link. - dev-null-sh/dev-null.sh#1196: Wraps profile handles in
UserPreviewto show the existing hovercard.
Suggested reviewers: hbenabdallah
Merge Risk: 
Minimal · up to b8001
-
The hovercard enhancement does not present an identified merge-blocking risk.
Pre-merge checks: 
5
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
commit-stargazers-dialog.tsxwraps each row inUserPreviewthe waychangelog-lane.tsxdoes inside its dialogValidation
Visual evidence
Device verification
UserPreviewopens for a mouse pointer and touch stays the sameIndependent review
75c969e1headb80015c9after a VISUAL FAIL round that asked for the 1366x650 capturesLimitations
Summary by CodeRabbit