Skip to content

refactor: call the user info handle prop a handle - #1190

Merged
nunomaduro merged 1 commit into
dev-null-sh:productionfrom
kachelle:refactor/user-info-show-handle
Oct 26, 2026
Merged

nunomaduro merged 1 commit into
dev-null-sh:productionfrom
kachelle:refactor/user-info-show-handle

Conversation

@kachelle

@kachelle kachelle commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

UserInfo shows @{user.handle} behind a showUsername prop, which #1179 missed when it renamed the username to the handle. It is now showHandle, in the component and the user menu, its only caller.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • User Interface
    • The user menu displays the account handle with an @ prefix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fd9fefc8-9075-4225-a1ba-df49884fbd9f
Commits

Reviewing files that changed from the base of the PR and between 3552f6e and 2ed85d2.

Files selected for processing: 2
  • resources/js/components/user-info.tsx
  • resources/js/components/user-menu-content.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

Walkthrough

UserInfo replaces the optional showUsername prop with showHandle. The user menu now passes showHandle to display the user handle.

Changes: User handle prop

Layer / File(s) Summary
Prop contract and caller
resources/js/components/user-info.tsx, resources/js/components/user-menu-content.tsx
UserInfo uses showHandle, defaulting to false, to control whether it renders the user handle. The user menu passes showHandle={true}.

Priority: Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Refactor

Possibly related PRs

  • dev-null-sh/dev-null.sh#1156: This PR added user.handle display while retaining the showUsername prop. The current change renames that prop and updates its caller.

Suggested reviewers: nunomaduro

Merge Risk: Minimal · up to 2ed85

The prop rename is consistent across the component and its only caller.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: renaming the UserInfo prop to use handle terminology.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@nunomaduro
nunomaduro merged commit 7e6c8a3 into dev-null-sh:production Oct 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants