[kachelle]

#990 and #886 merged after #1157 dropped the username from users, so they still looked it up there. They now use the profile handle.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Suggested-user lookups and dismissals now use profile handles to identify accounts, making these actions consistent with the handles shown on profiles.
  • Suggested-user requests can now find the intended profile by its handle, including when the account username differs.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The suggested-user API now validates and resolves users through profile handles. The dismissal route binds users by handle. Related tests now use handles in fixtures and profile-context requests; the API query parameter remains named username.

Changes: Suggested-user profile handle lookup

Layer / File(s)	Summary
Profile-handle lookup and route binding app/Http/Requests/ListApiSuggestedUsersRequest.php, routes/api.php, tests/Feature/Controllers/Api/SuggestedUserControllerTest.php, tests/Feature/Controllers/UserControllerTest.php	The request validates username against profiles.handle for user profiles and resolves context through the profile handle. The dismissal route binds by handle. Related test fixtures and profile-context values now use handles.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related issues

• dev-null-sh/dev-null.sh#1095 — The changed lookup uses profile handles for suggested-user discovery, but this PR does not add GitHub-based sourcing.
• dev-null-sh/dev-null.sh#897 — The PR changes suggested-user lookup, but the changes do not establish that the suggested-follow list-state behavior is fixed.

Possibly related PRs

• dev-null-sh/dev-null.sh#1178 — Makes the same suggested-user lookup and test updates.
• dev-null-sh/dev-null.sh#1157 — Removes users.username and makes profiles.handle the identity source that this PR now uses.
• dev-null-sh/dev-null.sh#1156 — Moves GitHub identity to profiles and introduces the handle contract used by this PR.

Suggested reviewers: taldres, hbenabdallah

Merge Risk: Moderate · up to 66e40

Update the dismissal tests to pass profile handles so CI validates the changed route contract.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[kachelle]

Closing, #1178 already fixed this the same way. Thanks @mnapoli for jumping on it so fast!