feat(sso): add idp_entity_id to SSOSAMLSettingsByMetadata#1567
Merged
Conversation
Add the optional idp_entity_id field, sent as entityId in the metadata configure body, so callers can persist the IdP entity ID alongside a metadata URL. This lets IdP-initiated SAML login resolve the tenant by the SAML response issuer. Backend: descope/backend#1280 Related issue: descope/etc#16175 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 |
![shuni-bot-dev[bot]](https://avatars.githubusercontent.com/u/97479186?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐕 Shuni's Review
Adds an optional idp_entity_id to SSOSAMLSettingsByMetadata, serialized as entityId in the metadata-config request so IdP-initiated login can resolve the tenant by SAML issuer.
No real issues found — good bones! The change is consistent with sibling fields (sent unconditionally, None matches spACSUrl/spEntityId), and tests are updated everywhere. One 🟢 LOW note inline on constructor arg ordering.
Woof! 🐕
aviadl
previously approved these changes
Jun 12, 2026
Address review feedback: move the new idp_entity_id parameter to the end of SSOSAMLSettingsByMetadata.__init__ so existing callers passing sp_acs_url/sp_entity_id positionally keep binding to the right fields. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
A dependency auto-bump set `mypy==2.1.0; python_version < '3.10'`, but mypy 2.1.0 requires Python >= 3.10, making dependency resolution unsatisfiable and breaking CI for all PRs. Restore the last 1.11.x line (1.11.2) as the in-file comment and prior revert intended; regenerate uv.lock to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)descope/management/sso_settings.py
|
aviadl
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional
idp_entity_idfield toSSOSAMLSettingsByMetadata, sent asentityIdin theconfigure_saml_settings_by_metadatarequest body.This lets callers persist the IdP entity ID alongside a metadata URL so IdP-initiated SAML login can resolve the tenant by the SAML response issuer. Without it, metadata-configured tenants had no stored entity ID and the issuer lookup failed (reported by Navan during SSO migration).
Backend PR: descope/backend#1280
Related issue: https://github.com/descope/etc/issues/16175
Must